Skip to content

const modifier on type parameters #51865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ahejlsberg merged 15 commits into from
Dec 16, 2022
Merged

const modifier on type parameters #51865

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
bd0ce7b
`const` modifier on type parameters + revised contextual type logic
ahejlsberg Dec 12, 2022
7c48b0d
Accept new baselines
ahejlsberg Dec 12, 2022
88c7149
Fix modifier checking
ahejlsberg Dec 12, 2022
ccf252f
Add tests
ahejlsberg Dec 12, 2022
f8fd1fd
Cache isConstTypeVariable check
ahejlsberg Dec 12, 2022
c3fcf6e
Revert "Cache isConstTypeVariable check"
ahejlsberg Dec 13, 2022
0507bf0
Fewer isConstTypeParameterContext checks
ahejlsberg Dec 13, 2022
b56d187
Pay attention to cached `undefined` contextual type
ahejlsberg Dec 13, 2022
54f649d
Allow `const` modifier in more places + properly print back
ahejlsberg Dec 13, 2022
d2af941
Also permit `const` in method signature type parameters
ahejlsberg Dec 13, 2022
a315761
Fix parsing of `const` modifier in array expression type parameters
ahejlsberg Dec 13, 2022
f6bbf9c
Accept new baselines
ahejlsberg Dec 13, 2022
636d937
Merge branch 'main' into fix30680
ahejlsberg Dec 13, 2022
dccb290
Remove unused properties from NodeLinks
ahejlsberg Dec 13, 2022
fde9c47
Rename `permitInvalidConstAsModifier` to `permitConstAsModifier`
ahejlsberg Dec 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix modifier checking
  • Loading branch information
@ahejlsberg
ahejlsberg committed Dec 12, 2022
commit 88c71495a48c5e348a3103d925a7bf351e3993ac
4 changes: 2 additions & 2 deletions src/compiler/checker.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45421,8 +45421,8 @@ export function createTypeChecker(host: TypeCheckerHost): TypeChecker {
if (node.kind !== SyntaxKind.EnumDeclaration && node.kind !== SyntaxKind.TypeParameter) {
return grammarErrorOnNode(node, Diagnostics.A_class_member_cannot_have_the_0_keyword, tokenToString(SyntaxKind.ConstKeyword));
}
if (node.kind === SyntaxKind.TypeParameter && !isFunctionLikeDeclaration(node.parent)) {
return grammarErrorOnNode(modifier, Diagnostics._0_modifier_can_only_appear_on_a_type_parameter_of_a_function_or_constructor, tokenToString(modifier.kind));
if (node.kind === SyntaxKind.TypeParameter && !(isFunctionLikeDeclaration(node.parent) || isClassDeclaration(node.parent))) {
return grammarErrorOnNode(modifier, Diagnostics._0_modifier_can_only_appear_on_a_type_parameter_of_a_function_method_or_class, tokenToString(modifier.kind));
}
break;
case SyntaxKind.OverrideKeyword:
Expand Down
2 changes: 1 addition & 1 deletion src/compiler/diagnosticMessages.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -907,7 +907,7 @@
"category": "Error",
"code": 1276
},
"'{0}' modifier can only appear on a type parameter of a function or constructor": {
"'{0}' modifier can only appear on a type parameter of a function, method or class": {
"category": "Error",
"code": 1277
},
Expand Down