Skip to content

Escape quotes when emitting React#5178

Merged
RyanCavanaugh merged 1 commit into
microsoft:masterfrom
RyanCavanaugh:fix5132
Oct 12, 2015
Merged

Escape quotes when emitting React#5178
RyanCavanaugh merged 1 commit into
microsoft:masterfrom
RyanCavanaugh:fix5132

Conversation

@RyanCavanaugh

Copy link
Copy Markdown
Member

Fixes #5132.

It's tempting to try to fix this on line 6903, but that breaks multi-line JSX text literals.

@yuit

yuit commented Oct 8, 2015

Copy link
Copy Markdown
Contributor

👍

1 similar comment
@mhegazy

mhegazy commented Oct 12, 2015

Copy link
Copy Markdown
Contributor

👍

RyanCavanaugh added a commit that referenced this pull request Oct 12, 2015
Escape quotes when emitting React
@RyanCavanaugh RyanCavanaugh merged commit c05297c into microsoft:master Oct 12, 2015
@RyanCavanaugh RyanCavanaugh deleted the fix5132 branch October 12, 2015 18:56
@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Double quotes in tsx are not escaped correctly in produced javascript

4 participants