Skip to content

Make resolution cache use sets instead of arrays for easier checking#51735

Merged
sheetalkamat merged 2 commits into
mainfrom
resolutionCacheFilesSet
Dec 6, 2022
Merged

Make resolution cache use sets instead of arrays for easier checking#51735
sheetalkamat merged 2 commits into
mainfrom
resolutionCacheFilesSet

Conversation

@sheetalkamat
Copy link
Copy Markdown
Member

@sheetalkamat sheetalkamat commented Dec 3, 2022

No description provided.

@DanielRosenwasser
Copy link
Copy Markdown
Member

DanielRosenwasser commented Dec 5, 2022

@typescript-bot perf test this faster

@typescript-bot
Copy link
Copy Markdown
Collaborator

typescript-bot commented Dec 5, 2022 •
edited
Loading

Heya @DanielRosenwasser, I've started to run the abridged perf test suite on this PR at 05eeb1a. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Copy Markdown
Collaborator

typescript-bot commented Dec 5, 2022

@DanielRosenwasser
The results of the perf run you requested are in!

Here they are:

Comparison Report - main..51735

Metric main 51735 Delta Best Worst
Angular - node (v16.17.1, x64)
Memory used 340,645k (± 0.01%) 340,656k (± 0.01%) +12k (+ 0.00%) 340,469k 340,722k
Parse Time 1.90s (± 0.88%) 1.90s (± 0.68%) +0.01s (+ 0.47%) 1.88s 1.93s
Bind Time 0.65s (± 0.90%) 0.65s (± 0.89%) +0.00s (+ 0.46%) 0.64s 0.66s
Check Time 5.17s (± 0.58%) 5.19s (± 0.41%) +0.02s (+ 0.43%) 5.14s 5.24s
Emit Time 5.15s (± 0.74%) 5.14s (± 0.95%) -0.01s (- 0.27%) 5.01s 5.22s
Total Time 12.86s (± 0.52%) 12.88s (± 0.53%) +0.01s (+ 0.11%) 12.74s 13.01s
Compiler-Unions - node (v16.17.1, x64)
Memory used 188,008k (± 0.63%) 186,671k (± 0.01%) -1,337k (- 0.71%) 186,608k 186,721k
Parse Time 0.79s (± 0.89%) 0.79s (± 0.84%) +0.00s (+ 0.13%) 0.78s 0.81s
Bind Time 0.42s (± 1.24%) 0.42s (± 0.95%) +0.00s (+ 0.48%) 0.41s 0.43s
Check Time 6.10s (± 0.66%) 6.09s (± 0.66%) -0.01s (- 0.08%) 5.97s 6.18s
Emit Time 1.95s (± 0.95%) 1.95s (± 0.71%) -0.00s (- 0.10%) 1.92s 1.98s
Total Time 9.26s (± 0.50%) 9.25s (± 0.44%) -0.00s (- 0.03%) 9.11s 9.33s
Monaco - node (v16.17.1, x64)
Memory used 319,828k (± 0.01%) 319,860k (± 0.05%) +32k (+ 0.01%) 319,744k 320,534k
Parse Time 1.41s (± 0.88%) 1.44s (± 0.40%) +0.02s (+ 1.70%) 1.42s 1.45s
Bind Time 0.59s (± 0.88%) 0.59s (± 1.01%) +0.01s (+ 1.02%) 0.58s 0.61s
Check Time 4.86s (± 0.53%) 4.88s (± 0.11%) +0.02s (+ 0.45%) 4.87s 4.89s
Emit Time 2.73s (± 1.32%) 2.75s (± 0.57%) +0.02s (+ 0.70%) 2.72s 2.79s
Total Time 9.58s (± 0.68%) 9.66s (± 0.27%) +0.07s (+ 0.77%) 9.59s 9.71s
TFS - node (v16.17.1, x64)
Memory used 282,292k (± 0.01%) 282,298k (± 0.01%) +6k (+ 0.00%) 282,269k 282,356k
Parse Time 1.16s (± 1.04%) 1.17s (± 0.80%) +0.01s (+ 1.21%) 1.16s 1.20s
Bind Time 0.66s (± 5.32%) 0.65s (± 3.84%) -0.01s (- 1.36%) 0.61s 0.69s
Check Time 4.75s (± 0.43%) 4.75s (± 0.25%) +0.00s (+ 0.04%) 4.73s 4.78s
Emit Time 2.79s (± 1.63%) 2.76s (± 1.64%) -0.02s (- 0.86%) 2.70s 2.89s
Total Time 9.36s (± 0.82%) 9.34s (± 0.70%) -0.02s (- 0.17%) 9.22s 9.54s
material-ui - node (v16.17.1, x64)
Memory used 435,323k (± 0.01%) 435,305k (± 0.01%) -18k (- 0.00%) 435,248k 435,351k
Parse Time 1.64s (± 0.50%) 1.66s (± 0.30%) +0.01s (+ 0.73%) 1.64s 1.66s
Bind Time 0.50s (± 0.89%) 0.50s (± 0.59%) +0.00s (+ 0.80%) 0.50s 0.51s
Check Time 11.82s (± 0.67%) 11.94s (± 0.69%) +0.11s (+ 0.97%) 11.77s 12.17s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 13.97s (± 0.62%) 14.09s (± 0.59%) +0.13s (+ 0.92%) 13.92s 14.33s
xstate - node (v16.17.1, x64)
Memory used 516,042k (± 0.02%) 516,095k (± 0.02%) +53k (+ 0.01%) 516,003k 516,374k
Parse Time 2.30s (± 0.36%) 2.32s (± 0.38%) +0.03s (+ 1.18%) 2.31s 2.34s
Bind Time 0.83s (± 1.29%) 0.85s (± 1.31%) +0.01s (+ 1.81%) 0.83s 0.87s
Check Time 1.36s (± 0.80%) 1.36s (± 0.64%) +0.00s (+ 0.29%) 1.34s 1.38s
Emit Time 0.06s (± 0.00%) 0.06s (± 0.00%) 0.00s ( 0.00%) 0.06s 0.06s
Total Time 4.55s (± 0.33%) 4.59s (± 0.29%) +0.04s (+ 0.92%) 4.57s 4.63s
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-131-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v16.17.1, x64)
Scenarios
  • Angular - node (v16.17.1, x64)
  • Compiler-Unions - node (v16.17.1, x64)
  • Monaco - node (v16.17.1, x64)
  • TFS - node (v16.17.1, x64)
  • material-ui - node (v16.17.1, x64)
  • xstate - node (v16.17.1, x64)
Benchmark Name Iterations
Current 51735 10
Baseline main 10

Developer Information:

Download Benchmark

@DanielRosenwasser
Copy link
Copy Markdown
Member

DanielRosenwasser commented Dec 5, 2022

@typescript-bot perf test this

@typescript-bot
Copy link
Copy Markdown
Collaborator

typescript-bot commented Dec 5, 2022 •
edited
Loading

Heya @DanielRosenwasser, I've started to run the perf test suite on this PR at 60c78e2. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Copy Markdown
Collaborator

typescript-bot commented Dec 5, 2022

@DanielRosenwasser
The results of the perf run you requested are in!

Here they are:

Compiler

Comparison Report - main..51735
Metric main 51735 Delta Best Worst
Angular - node (v18.10.0, x64)
Memory used 341,071k (± 0.02%) 341,110k (± 0.02%) +40k (+ 0.01%) 340,885k 341,192k
Parse Time 1.56s (± 0.68%) 1.57s (± 0.60%) +0.02s (+ 0.96%) 1.55s 1.59s
Bind Time 0.52s (± 0.72%) 0.52s (± 0.85%) +0.01s (+ 1.36%) 0.51s 0.53s
Check Time 3.99s (± 0.38%) 4.01s (± 0.73%) +0.02s (+ 0.48%) 3.95s 4.08s
Emit Time 4.27s (± 0.64%) 4.26s (± 1.01%) -0.01s (- 0.28%) 4.20s 4.42s
Total Time 10.33s (± 0.29%) 10.36s (± 0.72%) +0.03s (+ 0.28%) 10.22s 10.62s
Compiler-Unions - node (v18.10.0, x64)
Memory used 186,785k (± 1.02%) 185,639k (± 0.65%) -1,146k (- 0.61%) 185,009k 190,478k
Parse Time 0.61s (± 0.85%) 0.61s (± 1.23%) +0.01s (+ 0.82%) 0.59s 0.63s
Bind Time 0.33s (± 1.36%) 0.33s (± 1.04%) -0.00s (- 0.30%) 0.32s 0.33s
Check Time 4.99s (± 0.43%) 5.04s (± 0.51%) +0.05s (+ 1.00%) 4.98s 5.11s
Emit Time 1.54s (± 1.38%) 1.55s (± 0.96%) +0.01s (+ 0.78%) 1.52s 1.58s
Total Time 7.47s (± 0.44%) 7.54s (± 0.60%) +0.07s (+ 0.92%) 7.44s 7.65s
Monaco - node (v18.10.0, x64)
Memory used 320,463k (± 0.02%) 320,440k (± 0.02%) -23k (- 0.01%) 320,306k 320,581k
Parse Time 1.14s (± 0.99%) 1.15s (± 0.76%) +0.01s (+ 1.23%) 1.14s 1.18s
Bind Time 0.48s (± 1.84%) 0.49s (± 1.22%) +0.00s (+ 0.41%) 0.47s 0.50s
Check Time 3.85s (± 0.81%) 3.84s (± 0.54%) -0.01s (- 0.26%) 3.80s 3.89s
Emit Time 2.25s (± 1.26%) 2.25s (± 0.53%) -0.01s (- 0.27%) 2.22s 2.27s
Total Time 7.73s (± 0.87%) 7.73s (± 0.47%) +0.00s (+ 0.03%) 7.67s 7.81s
TFS - node (v18.10.0, x64)
Memory used 283,518k (± 0.23%) 283,268k (± 0.19%) -249k (- 0.09%) 282,812k 284,894k
Parse Time 0.94s (± 1.41%) 0.97s (± 2.48%) +0.02s (+ 2.44%) 0.92s 1.02s
Bind Time 0.48s (± 8.94%) 0.44s (± 1.41%) 🟩-0.04s (- 8.73%) 0.43s 0.45s
Check Time 3.76s (± 0.63%) 3.78s (± 0.57%) +0.02s (+ 0.59%) 3.74s 3.83s
Emit Time 2.21s (± 0.75%) 2.20s (± 1.21%) -0.01s (- 0.45%) 2.15s 2.27s
Total Time 7.40s (± 0.62%) 7.39s (± 0.78%) -0.01s (- 0.12%) 7.26s 7.53s
material-ui - node (v18.10.0, x64)
Memory used 435,896k (± 0.00%) 435,914k (± 0.01%) +18k (+ 0.00%) 435,843k 436,166k
Parse Time 1.31s (± 0.79%) 1.31s (± 0.59%) -0.00s (- 0.08%) 1.30s 1.33s
Bind Time 0.49s (± 2.02%) 0.50s (± 1.01%) +0.01s (+ 1.43%) 0.49s 0.51s
Check Time 10.24s (± 0.32%) 10.26s (± 0.85%) +0.03s (+ 0.26%) 10.10s 10.52s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 12.04s (± 0.36%) 12.07s (± 0.71%) +0.03s (+ 0.27%) 11.89s 12.33s
xstate - node (v18.10.0, x64)
Memory used 518,406k (± 0.01%) 518,420k (± 0.02%) +14k (+ 0.00%) 518,269k 518,647k
Parse Time 1.88s (± 0.64%) 1.89s (± 0.64%) +0.01s (+ 0.59%) 1.87s 1.92s
Bind Time 0.70s (± 2.91%) 0.70s (± 0.52%) +0.00s (+ 0.28%) 0.70s 0.71s
Check Time 1.04s (± 0.90%) 1.05s (± 0.72%) +0.00s (+ 0.29%) 1.03s 1.06s
Emit Time 0.05s (± 0.00%) 0.05s (± 0.00%) 0.00s ( 0.00%) 0.05s 0.05s
Total Time 3.68s (± 0.77%) 3.70s (± 0.38%) +0.02s (+ 0.46%) 3.66s 3.72s
Angular - node (v16.17.1, x64)
Memory used 340,535k (± 0.00%) 340,511k (± 0.02%) -23k (- 0.01%) 340,312k 340,567k
Parse Time 1.86s (± 0.55%) 1.87s (± 0.60%) +0.01s (+ 0.54%) 1.85s 1.89s
Bind Time 0.65s (± 0.58%) 0.65s (± 0.53%) +0.00s (+ 0.31%) 0.64s 0.65s
Check Time 5.15s (± 0.58%) 5.13s (± 0.78%) -0.01s (- 0.21%) 5.07s 5.23s
Emit Time 5.11s (± 0.81%) 5.12s (± 1.23%) +0.01s (+ 0.20%) 4.98s 5.21s
Total Time 12.77s (± 0.48%) 12.77s (± 0.75%) +0.01s (+ 0.06%) 12.60s 12.95s
Compiler-Unions - node (v16.17.1, x64)
Memory used 188,019k (± 0.64%) 187,324k (± 0.53%) -696k (- 0.37%) 186,588k 189,997k
Parse Time 0.79s (± 0.76%) 0.80s (± 0.75%) +0.01s (+ 1.15%) 0.78s 0.81s
Bind Time 0.42s (± 0.82%) 0.42s (± 0.53%) +0.00s (+ 0.96%) 0.42s 0.43s
Check Time 6.02s (± 0.51%) 6.10s (± 0.57%) +0.08s (+ 1.33%) 6.04s 6.17s
Emit Time 1.93s (± 0.82%) 1.94s (± 0.66%) +0.01s (+ 0.36%) 1.91s 1.98s
Total Time 9.15s (± 0.44%) 9.25s (± 0.42%) +0.10s (+ 1.05%) 9.19s 9.36s
Monaco - node (v16.17.1, x64)
Memory used 319,766k (± 0.01%) 319,780k (± 0.01%) +14k (+ 0.00%) 319,725k 319,855k
Parse Time 1.41s (± 0.68%) 1.41s (± 0.59%) 0.00s ( 0.00%) 1.39s 1.43s
Bind Time 0.59s (± 1.09%) 0.59s (± 0.83%) +0.00s (+ 0.34%) 0.58s 0.60s
Check Time 4.86s (± 0.58%) 4.86s (± 0.33%) 0.00s ( 0.00%) 4.82s 4.89s
Emit Time 2.73s (± 1.06%) 2.74s (± 0.84%) +0.01s (+ 0.37%) 2.70s 2.81s
Total Time 9.59s (± 0.46%) 9.60s (± 0.34%) +0.01s (+ 0.11%) 9.51s 9.65s
TFS - node (v16.17.1, x64)
Memory used 282,309k (± 0.01%) 282,306k (± 0.01%) -3k (- 0.00%) 282,250k 282,350k
Parse Time 1.15s (± 0.86%) 1.15s (± 0.84%) -0.00s (- 0.26%) 1.13s 1.18s
Bind Time 0.62s (± 5.67%) 0.63s (± 5.41%) +0.01s (+ 1.77%) 0.57s 0.69s
Check Time 4.74s (± 0.43%) 4.75s (± 0.40%) +0.01s (+ 0.17%) 4.71s 4.78s
Emit Time 2.78s (± 1.68%) 2.78s (± 2.29%) -0.00s (- 0.14%) 2.67s 2.90s
Total Time 9.30s (± 0.71%) 9.31s (± 0.72%) +0.01s (+ 0.14%) 9.19s 9.45s
material-ui - node (v16.17.1, x64)
Memory used 435,308k (± 0.01%) 435,264k (± 0.01%) -44k (- 0.01%) 435,182k 435,317k
Parse Time 1.62s (± 0.93%) 1.63s (± 0.54%) +0.01s (+ 0.37%) 1.61s 1.65s
Bind Time 0.50s (± 0.98%) 0.51s (± 0.58%) +0.00s (+ 0.79%) 0.50s 0.51s
Check Time 11.79s (± 0.79%) 11.78s (± 0.65%) -0.00s (- 0.03%) 11.63s 11.96s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 13.91s (± 0.70%) 13.92s (± 0.59%) +0.01s (+ 0.05%) 13.74s 14.09s
xstate - node (v16.17.1, x64)
Memory used 516,044k (± 0.01%) 516,000k (± 0.01%) -44k (- 0.01%) 515,940k 516,165k
Parse Time 2.25s (± 0.22%) 2.27s (± 0.31%) +0.02s (+ 0.71%) 2.26s 2.29s
Bind Time 0.83s (± 1.01%) 0.83s (± 1.38%) +0.00s (+ 0.36%) 0.81s 0.87s
Check Time 1.34s (± 0.79%) 1.35s (± 0.60%) +0.01s (+ 0.67%) 1.33s 1.37s
Emit Time 0.06s (± 0.00%) 0.06s (± 0.00%) 0.00s ( 0.00%) 0.06s 0.06s
Total Time 4.49s (± 0.21%) 4.52s (± 0.35%) +0.03s (+ 0.62%) 4.49s 4.56s
Angular - node (v14.15.1, x64)
Memory used 333,986k (± 0.01%) 333,986k (± 0.00%) -1k (- 0.00%) 333,961k 334,013k
Parse Time 2.04s (± 0.43%) 2.04s (± 0.61%) +0.01s (+ 0.34%) 2.03s 2.08s
Bind Time 0.70s (± 0.83%) 0.70s (± 0.82%) +0.00s (+ 0.43%) 0.69s 0.71s
Check Time 5.50s (± 0.83%) 5.52s (± 0.63%) +0.02s (+ 0.31%) 5.42s 5.58s
Emit Time 5.35s (± 0.67%) 5.34s (± 0.79%) -0.00s (- 0.04%) 5.23s 5.42s
Total Time 13.58s (± 0.55%) 13.60s (± 0.52%) +0.02s (+ 0.16%) 13.46s 13.75s
Compiler-Unions - node (v14.15.1, x64)
Memory used 182,649k (± 0.61%) 182,682k (± 0.63%) +33k (+ 0.02%) 181,605k 185,108k
Parse Time 0.89s (± 0.50%) 0.90s (± 0.96%) +0.01s (+ 1.13%) 0.88s 0.92s
Bind Time 0.45s (± 0.80%) 0.46s (± 0.87%) +0.00s (+ 1.10%) 0.45s 0.47s
Check Time 6.34s (± 0.64%) 6.39s (± 0.57%) +0.04s (+ 0.68%) 6.30s 6.46s
Emit Time 2.06s (± 1.04%) 2.04s (± 0.82%) -0.02s (- 0.73%) 2.00s 2.08s
Total Time 9.74s (± 0.59%) 9.79s (± 0.40%) +0.04s (+ 0.45%) 9.69s 9.85s
Monaco - node (v14.15.1, x64)
Memory used 314,576k (± 0.01%) 314,600k (± 0.01%) +24k (+ 0.01%) 314,534k 314,658k
Parse Time 1.55s (± 0.36%) 1.56s (± 0.52%) +0.00s (+ 0.32%) 1.54s 1.58s
Bind Time 0.63s (± 0.54%) 0.63s (± 0.63%) -0.00s (- 0.32%) 0.62s 0.64s
Check Time 5.16s (± 0.46%) 5.19s (± 0.33%) +0.03s (+ 0.50%) 5.14s 5.22s
Emit Time 2.89s (± 0.53%) 2.90s (± 0.96%) +0.01s (+ 0.38%) 2.83s 2.94s
Total Time 10.23s (± 0.27%) 10.28s (± 0.31%) +0.04s (+ 0.42%) 10.22s 10.34s
TFS - node (v14.15.1, x64)
Memory used 279,356k (± 0.00%) 279,383k (± 0.00%) +27k (+ 0.01%) 279,361k 279,404k
Parse Time 1.32s (± 0.89%) 1.34s (± 1.49%) +0.02s (+ 1.44%) 1.31s 1.40s
Bind Time 0.59s (± 0.88%) 0.59s (± 0.68%) 0.00s ( 0.00%) 0.58s 0.60s
Check Time 5.08s (± 0.28%) 5.07s (± 0.27%) -0.01s (- 0.20%) 5.04s 5.10s
Emit Time 3.08s (± 0.42%) 3.10s (± 0.96%) +0.02s (+ 0.68%) 3.05s 3.19s
Total Time 10.08s (± 0.22%) 10.11s (± 0.41%) +0.03s (+ 0.29%) 10.01s 10.20s
material-ui - node (v14.15.1, x64)
Memory used 430,736k (± 0.01%) 430,751k (± 0.01%) +15k (+ 0.00%) 430,701k 430,804k
Parse Time 1.85s (± 0.80%) 1.87s (± 1.18%) +0.01s (+ 0.76%) 1.82s 1.92s
Bind Time 0.53s (± 0.84%) 0.53s (± 0.63%) +0.00s (+ 0.38%) 0.52s 0.54s
Check Time 12.20s (± 0.34%) 12.20s (± 0.56%) -0.00s (- 0.02%) 12.08s 12.38s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 14.58s (± 0.29%) 14.59s (± 0.57%) +0.01s (+ 0.08%) 14.48s 14.82s
xstate - node (v14.15.1, x64)
Memory used 504,375k (± 0.01%) 504,391k (± 0.01%) +16k (+ 0.00%) 504,236k 504,449k
Parse Time 2.56s (± 0.65%) 2.56s (± 0.53%) +0.00s (+ 0.08%) 2.53s 2.59s
Bind Time 0.84s (± 0.79%) 0.84s (± 0.90%) +0.00s (+ 0.24%) 0.83s 0.86s
Check Time 1.48s (± 0.85%) 1.49s (± 0.56%) +0.01s (+ 0.68%) 1.46s 1.50s
Emit Time 0.07s (± 0.00%) 0.07s (± 0.00%) 0.00s ( 0.00%) 0.07s 0.07s
Total Time 4.95s (± 0.41%) 4.97s (± 0.41%) +0.02s (+ 0.34%) 4.93s 5.02s
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-131-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v18.10.0, x64)
  • node (v16.17.1, x64)
  • node (v14.15.1, x64)
Scenarios
  • Angular - node (v18.10.0, x64)
  • Angular - node (v16.17.1, x64)
  • Angular - node (v14.15.1, x64)
  • Compiler-Unions - node (v18.10.0, x64)
  • Compiler-Unions - node (v16.17.1, x64)
  • Compiler-Unions - node (v14.15.1, x64)
  • Monaco - node (v18.10.0, x64)
  • Monaco - node (v16.17.1, x64)
  • Monaco - node (v14.15.1, x64)
  • TFS - node (v18.10.0, x64)
  • TFS - node (v16.17.1, x64)
  • TFS - node (v14.15.1, x64)
  • material-ui - node (v18.10.0, x64)
  • material-ui - node (v16.17.1, x64)
  • material-ui - node (v14.15.1, x64)
  • xstate - node (v18.10.0, x64)
  • xstate - node (v16.17.1, x64)
  • xstate - node (v14.15.1, x64)
Benchmark Name Iterations
Current 51735 10
Baseline main 10

TSServer

Comparison Report - main..51735
Metric main 51735 Delta Best Worst
Compiler-UnionsTSServer - node (v18.10.0, x64)
Req 1 - updateOpen 1,047ms (± 0.43%) 1,050ms (± 0.67%) +3ms (+ 0.31%) 1,037ms 1,066ms
Req 2 - geterr 2,571ms (± 0.74%) 2,568ms (± 0.79%) -3ms (- 0.10%) 2,525ms 2,620ms
Req 3 - references 164ms (± 0.61%) 165ms (± 0.50%) +0ms (+ 0.18%) 163ms 167ms
Req 4 - navto 138ms (± 0.59%) 138ms (± 0.54%) +1ms (+ 0.44%) 137ms 140ms
Req 5 - completionInfo count 1,356 (± 0.00%) 1,356 (± 0.00%) 0 ( 0.00%) 1,356 1,356
Req 5 - completionInfo 60ms (± 2.25%) 63ms (± 2.58%) +3ms (+ 4.84%) 61ms 69ms
CompilerTSServer - node (v18.10.0, x64)
Req 1 - updateOpen 1,098ms (± 0.75%) 1,103ms (± 0.73%) +5ms (+ 0.49%) 1,084ms 1,123ms
Req 2 - geterr 1,598ms (± 0.42%) 1,593ms (± 0.55%) -5ms (- 0.34%) 1,576ms 1,619ms
Req 3 - references 167ms (± 0.33%) 169ms (± 0.71%) +2ms (+ 0.90%) 166ms 171ms
Req 4 - navto 150ms (± 0.73%) 152ms (± 0.54%) +2ms (+ 1.33%) 150ms 154ms
Req 5 - completionInfo count 1,518 (± 0.00%) 1,518 (± 0.00%) 0 ( 0.00%) 1,518 1,518
Req 5 - completionInfo 52ms (± 1.00%) 53ms (± 1.63%) +1ms (+ 2.11%) 51ms 55ms
xstateTSServer - node (v18.10.0, x64)
Req 1 - updateOpen 1,488ms (± 0.47%) 1,513ms (± 1.05%) +24ms (+ 1.64%) 1,491ms 1,565ms
Req 2 - geterr 559ms (± 0.70%) 554ms (± 0.64%) -5ms (- 0.81%) 546ms 563ms
Req 3 - references 58ms (± 1.51%) 59ms (± 2.43%) +0ms (+ 0.34%) 57ms 62ms
Req 4 - navto 196ms (± 1.03%) 196ms (± 0.64%) -1ms (- 0.25%) 192ms 198ms
Req 5 - completionInfo count 3,154 (± 0.00%) 3,154 (± 0.00%) 0 ( 0.00%) 3,154 3,154
Req 5 - completionInfo 214ms (± 1.42%) 212ms (± 1.47%) -2ms (- 0.75%) 207ms 221ms
Compiler-UnionsTSServer - node (v16.17.1, x64)
Req 1 - updateOpen 1,298ms (± 0.61%) 1,311ms (± 0.96%) +14ms (+ 1.05%) 1,288ms 1,340ms
Req 2 - geterr 3,180ms (± 0.83%) 3,210ms (± 0.92%) +29ms (+ 0.92%) 3,122ms 3,265ms
Req 3 - references 191ms (± 0.80%) 191ms (± 0.91%) +0ms (+ 0.10%) 188ms 195ms
Req 4 - navto 150ms (± 0.89%) 152ms (± 0.93%) +2ms (+ 1.34%) 148ms 154ms
Req 5 - completionInfo count 1,356 (± 0.00%) 1,356 (± 0.00%) 0 ( 0.00%) 1,356 1,356
Req 5 - completionInfo 61ms (± 4.59%) 62ms (± 6.30%) +1ms (+ 1.49%) 57ms 72ms
CompilerTSServer - node (v16.17.1, x64)
Req 1 - updateOpen 1,385ms (± 0.84%) 1,388ms (± 0.79%) +3ms (+ 0.19%) 1,371ms 1,418ms
Req 2 - geterr 2,104ms (± 0.35%) 2,096ms (± 0.59%) -8ms (- 0.37%) 2,069ms 2,125ms
Req 3 - references 197ms (± 0.41%) 199ms (± 0.75%) +2ms (+ 1.07%) 197ms 203ms
Req 4 - navto 166ms (± 1.50%) 167ms (± 1.18%) +1ms (+ 0.66%) 163ms 172ms
Req 5 - completionInfo count 1,518 (± 0.00%) 1,518 (± 0.00%) 0 ( 0.00%) 1,518 1,518
Req 5 - completionInfo 56ms (± 2.05%) 57ms (± 2.71%) +1ms (+ 1.60%) 54ms 60ms
xstateTSServer - node (v16.17.1, x64)
Req 1 - updateOpen 1,812ms (± 0.66%) 1,814ms (± 0.60%) +2ms (+ 0.10%) 1,791ms 1,836ms
Req 2 - geterr 719ms (± 0.71%) 718ms (± 0.57%) -1ms (- 0.17%) 708ms 727ms
Req 3 - references 68ms (± 1.22%) 67ms (± 1.11%) -0ms (- 0.44%) 66ms 69ms
Req 4 - navto 198ms (± 0.86%) 198ms (± 0.60%) -0ms (- 0.05%) 195ms 200ms
Req 5 - completionInfo count 3,154 (± 0.00%) 3,154 (± 0.00%) 0 ( 0.00%) 3,154 3,154
Req 5 - completionInfo 254ms (± 0.85%) 254ms (± 0.94%) -0ms (- 0.12%) 247ms 259ms
Compiler-UnionsTSServer - node (v14.15.1, x64)
Req 1 - updateOpen 1,444ms (± 0.64%) 1,452ms (± 0.84%) +8ms (+ 0.53%) 1,430ms 1,478ms
Req 2 - geterr 3,424ms (± 0.80%) 3,423ms (± 0.68%) -1ms (- 0.03%) 3,392ms 3,489ms
Req 3 - references 205ms (± 0.94%) 206ms (± 0.79%) +1ms (+ 0.54%) 203ms 210ms
Req 4 - navto 162ms (± 0.62%) 163ms (± 1.00%) +1ms (+ 0.31%) 159ms 168ms
Req 5 - completionInfo count 1,356 (± 0.00%) 1,356 (± 0.00%) 0 ( 0.00%) 1,356 1,356
Req 5 - completionInfo 57ms (± 0.91%) 57ms (± 0.97%) +0ms (+ 0.53%) 56ms 58ms
CompilerTSServer - node (v14.15.1, x64)
Req 1 - updateOpen 1,530ms (± 0.50%) 1,533ms (± 0.41%) +4ms (+ 0.24%) 1,522ms 1,547ms
Req 2 - geterr 2,284ms (± 0.56%) 2,281ms (± 0.51%) -3ms (- 0.12%) 2,258ms 2,307ms
Req 3 - references 216ms (± 1.21%) 217ms (± 1.17%) +1ms (+ 0.46%) 214ms 224ms
Req 4 - navto 175ms (± 0.64%) 175ms (± 1.03%) +0ms (+ 0.17%) 171ms 181ms
Req 5 - completionInfo count 1,518 (± 0.00%) 1,518 (± 0.00%) 0 ( 0.00%) 1,518 1,518
Req 5 - completionInfo 56ms (± 1.55%) 56ms (± 1.00%) 0ms ( 0.00%) 55ms 57ms
xstateTSServer - node (v14.15.1, x64)
Req 1 - updateOpen 2,008ms (± 0.36%) 2,014ms (± 0.78%) +6ms (+ 0.28%) 1,987ms 2,054ms
Req 2 - geterr 745ms (± 0.44%) 749ms (± 0.59%) +4ms (+ 0.54%) 739ms 757ms
Req 3 - references 72ms (± 1.41%) 73ms (± 1.67%) +1ms (+ 1.40%) 69ms 75ms
Req 4 - navto 217ms (± 1.07%) 220ms (± 0.72%) +2ms (+ 1.10%) 216ms 222ms
Req 5 - completionInfo count 3,154 (± 0.00%) 3,154 (± 0.00%) 0 ( 0.00%) 3,154 3,154
Req 5 - completionInfo 272ms (± 1.87%) 271ms (± 1.12%) -1ms (- 0.22%) 267ms 281ms
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-131-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v18.10.0, x64)
  • node (v16.17.1, x64)
  • node (v14.15.1, x64)
Scenarios
  • Compiler-UnionsTSServer - node (v18.10.0, x64)
  • Compiler-UnionsTSServer - node (v16.17.1, x64)
  • Compiler-UnionsTSServer - node (v14.15.1, x64)
  • CompilerTSServer - node (v18.10.0, x64)
  • CompilerTSServer - node (v16.17.1, x64)
  • CompilerTSServer - node (v14.15.1, x64)
  • xstateTSServer - node (v18.10.0, x64)
  • xstateTSServer - node (v16.17.1, x64)
  • xstateTSServer - node (v14.15.1, x64)
Benchmark Name Iterations
Current 51735 10
Baseline main 10

Startup

Comparison Report - main..51735
Metric main 51735 Delta Best Worst
tsc-startup - node (v16.17.1, x64)
Execution time 117.20ms (± 0.37%) 117.89ms (± 0.39%) +0.69ms (+ 0.59%) 115.67ms 123.95ms
tsserver-startup - node (v16.17.1, x64)
Execution time 197.62ms (± 0.33%) 199.90ms (± 0.42%) +2.28ms (+ 1.15%) 195.83ms 210.38ms
tsserverlibrary-startup - node (v16.17.1, x64)
Execution time 191.56ms (± 0.30%) 195.44ms (± 0.47%) +3.88ms (+ 2.02%) 189.25ms 204.51ms
typescript-startup - node (v16.17.1, x64)
Execution time 177.08ms (± 0.40%) 181.05ms (± 0.43%) +3.97ms (+ 2.24%) 175.82ms 188.18ms
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-131-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v16.17.1, x64)
Scenarios
  • tsc-startup - node (v16.17.1, x64)
  • tsserver-startup - node (v16.17.1, x64)
  • tsserverlibrary-startup - node (v16.17.1, x64)
  • typescript-startup - node (v16.17.1, x64)
Benchmark Name Iterations
Current 51735 10
Baseline main 10

Developer Information:

Download Benchmark

@sheetalkamat sheetalkamat mentioned this pull request Dec 6, 2022
Merged
@sheetalkamat sheetalkamat merged commit 84e475c into main Dec 6, 2022
@sheetalkamat sheetalkamat deleted the resolutionCacheFilesSet branch December 6, 2022 22:25
@sheetalkamat
Copy link
Copy Markdown
Member Author

sheetalkamat commented Dec 6, 2022

After talking to @DanielRosenwasser and confirming that his perf concerns were infact noise merging this in

@microsoft microsoft locked as resolved and limited conversation to collaborators Oct 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@andrewbranch andrewbranch andrewbranch approved these changes

@jakebailey jakebailey Awaiting requested review from jakebailey

Assignees

@sheetalkamat sheetalkamat

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sheetalkamat @DanielRosenwasser @typescript-bot @andrewbranch