Fix simple uses of polymorphic this in services#5169
Merged
sandersn merged 4 commits intoOct 12, 2015
Conversation
1. Completion after `this.` was empty. 2. Quick info of methods with overloads always chose the first overload, regardless of whether an argument whose type matched a different overload. Both have the same cause: the type parameter introduced by polymorphic `this` is not usable, whereas the original is. In both cases, the usage is simple -- it doesn't take advantage of the capabilities of polymorphic `this`.
|
Hi @sandersn, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
TTYL, MSBOT; |
Member
Author
|
lint errors. I'll fix and push a new commit |
Member
There was a problem hiding this comment.
"Get the first signature if there is one."
Contributor
|
👍 |
Member
|
👍 |
sandersn
added a commit
that referenced
this pull request
Oct 12, 2015
…c-this-in-services Fix simple uses of polymorphic this in services
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this.was empty.regardless of whether an argument whose type matched a different overload.
Both have the same cause: the type parameter introduced by polymorphic
thisis not usable, whereas the original is. In both cases, the usage is simple -- it doesn't take advantage of the capabilities ofpolymorphic
this.Fixes #5038