Code refactoring for module resolution api#51675
Merged
Merged
Conversation
… before solving, so ResolutionCache doesnt need this check
… doesnt update own options
…mon scenarios so cache can be shared between redirects
42b4770 to
39978b0
Compare
andrewbranch
reviewed
Dec 1, 2022
| Info 59 [00:01:34.000] response: | ||
| { | ||
| "responseRequired": false | ||
| } No newline at end of file |
Member
There was a problem hiding this comment.
I can’t figure out where the relevant part of these baselines is. Is it possible to write the contrasting sharing/not-sharing tests in a way that asserts only the relevant difference instead of creating two very large baselines that are nearly identical?
Member
There was a problem hiding this comment.
The relevant part is visible in isolation in 39978b0
Member
Author
There was a problem hiding this comment.
Agreed diff would be great but that’s not easy with current baselines and traces .. so tried to keep it same as tsserver log that we anyways use for debugging user issues too ..
andrewbranch
approved these changes
Dec 1, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is first few commits of #51546 and can be taken without that change.
Simplified
CacheWithRedirectslogic to use Map from options now that we are using native maps 4018f1b, 39978b0