Skip to content

Error message should be fixed for ambient module inside namespace#5050

Merged
DanielRosenwasser merged 2 commits into
microsoft:masterfrom
plantain-00:issue4701
Oct 1, 2015
Merged

Error message should be fixed for ambient module inside namespace#5050
DanielRosenwasser merged 2 commits into
microsoft:masterfrom
plantain-00:issue4701

Conversation

@plantain-00
Copy link
Copy Markdown
Contributor

to fix #4701.

@msftclas
Copy link
Copy Markdown

msftclas commented Oct 1, 2015

Hi @plantain-00, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.

TTYL, MSBOT;

@weswigham
Copy link
Copy Markdown
Member

You'll also need to change the reference to the generated variable this json file makes to be correct. Specifically, line 13456 of checker.ts.

@plantain-00
Copy link
Copy Markdown
Contributor Author

I see.
I forgot to run tests.
I'm on it.

@DanielRosenwasser
Copy link
Copy Markdown
Member

Awesome, thanks for the PR @plantain-00!

DanielRosenwasser added a commit that referenced this pull request Oct 1, 2015
Error message should be fixed for ambient module inside namespace
@DanielRosenwasser DanielRosenwasser merged commit dfb95b8 into microsoft:master Oct 1, 2015
@plantain-00 plantain-00 deleted the issue4701 branch December 7, 2015 23:24
@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error message should be fixed for ambient module inside namespace

4 participants