Get linter integrated into build/test process#5048
Merged
weswigham merged 3 commits intoOct 1, 2015
Conversation
Member
|
👍 |
Member
There was a problem hiding this comment.
Remove this just because it's not actually using null.
Member
Author
There was a problem hiding this comment.
It uses null on line 76 as part of the runBaseline api.
Member
|
Other than that, 👍 |
weswigham
added a commit
that referenced
this pull request
Oct 1, 2015
Get linter integrated into build/test process
|
@weswigham Can you file an issue on TSLint about the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By fixing every lint issue in the compiler/services/harness, and disabling the
no-unreachableandno-use-before-declarerules. Both of these had issues with various constructs used in the compiler and yielded false positives. (no-unreachableis triggered by local interface declarations and type aliases, when both behave as though hoisted.no-use-before-declaredoesn't handle exported namespace members which are out-of-order.) Both can but re-enabled in the future when they get fixed.no-nullis disabled in most of the harness as @DanielRosenwasser mentioned that it used null as part of its API.Hopefully this should save @DanielRosenwasser some time on CRs. 😄