Allow /* comments between < and JSX element name#5007
Merged
Conversation
Member
There was a problem hiding this comment.
We could add a lint for this. No lies. Alongside 'no-null' we can have 'no-debugger'.
Member
There was a problem hiding this comment.
Sure, but have you ever considered how much I enjoy doing this?
Member
|
Apart from the |
Contributor
|
👍 |
Contributor
There was a problem hiding this comment.
i would move the languageVariant === LanguageVariant.JSX to the beginning of the if condition, just to save the two extra dispatches in the negative case.
Contributor
|
👍 |
RyanCavanaugh
added a commit
that referenced
this pull request
Sep 29, 2015
Allow /* comments between < and JSX element name
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue #4514