Fix for importing modules from definitions#493
Merged
Conversation
Member
There was a problem hiding this comment.
I believe CompilerHosts interact with the compiler itself, where we entirely avoid the use of null. This should be undefined.
Contributor
|
Thanks @RReverser. we will you to fill out the Contributor License Agreement (CLA). Download the agreement (Microsoft Contribution License Agreement.docx), sign, scan, and email it back to cla@microsoft.com. see https://github.com/Microsoft/TypeScript/blob/master/CONTRIBUTING.md for more details |
Contributor
Author
|
@mhegazy Did that and rebased patch on top of current master. |
Contributor
|
Thanks @RReverser! |
mhegazy
added a commit
that referenced
this pull request
Sep 3, 2014
Fix for importing modules from definitions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please see #492 for bug description.
Removed assertion in
getSourceFilesinceprocessSourceFileobviously expectsfindSourceFileto return falsy value fromfindSourceFile(which is wrapper aroundgetSourceFileresult) when file is not found, and not to fail in that case.