Skip to content

Start Node ESM stable version at Node16 #48879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DanielRosenwasser merged 12 commits into from
May 3, 2022
Merged

Start Node ESM stable version at Node16 #48879

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
c0f2882
Remove Node12, add Node16.
DanielRosenwasser Apr 28, 2022
52d1ea5
Accepted baselines.
DanielRosenwasser Apr 28, 2022
1247217
Refactor checking for top-level await, give a better error message in…
DanielRosenwasser Apr 29, 2022
c390b79
Accepted baselines.
DanielRosenwasser Apr 29, 2022
8b1e656
Stop erroring on JSON module imports in node ESM since they're no lon…
DanielRosenwasser Apr 29, 2022
ce98f0a
Accepted baselines.
DanielRosenwasser Apr 29, 2022
fac5ded
More refactoring, do the same checks for for-await loops.
DanielRosenwasser Apr 29, 2022
5305796
Accepted baselines.
DanielRosenwasser Apr 29, 2022
1ca971d
Adjust phrasing to permit for-await on CJS error.
DanielRosenwasser Apr 29, 2022
4c46f26
Accepted baselines.
DanielRosenwasser Apr 29, 2022
830871c
Accepted baselines.
DanielRosenwasser Apr 29, 2022
9d7fae8
Fix lints.
DanielRosenwasser Apr 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Accepted baselines.
  • Loading branch information
@DanielRosenwasser
DanielRosenwasser authored Apr 29, 2022
commit 4c46f26ab9139ba4a321f9dc5931dfc5385b70ba
8 changes: 4 additions & 4 deletions tests/baselines/reference/nodeModulesAllowJsTopLevelAwait(module=node16).errors.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,16 @@
tests/cases/conformance/node/allowJs/subfolder/index.js(2,11): error TS1309: The current file is a CommonJS module and cannot use 'await' expressions at the top-level.
tests/cases/conformance/node/allowJs/subfolder/index.js(4,5): error TS1309: The current file is a CommonJS module and cannot use 'await' expressions at the top-level.
tests/cases/conformance/node/allowJs/subfolder/index.js(2,11): error TS1309: The current file is a CommonJS module and cannot use 'await' at the top level.
tests/cases/conformance/node/allowJs/subfolder/index.js(4,5): error TS1309: The current file is a CommonJS module and cannot use 'await' at the top level.


==== tests/cases/conformance/node/allowJs/subfolder/index.js (2 errors) ====
// cjs format file
const x = await 1;
~~~~~
!!! error TS1309: The current file is a CommonJS module and cannot use 'await' expressions at the top-level.
!!! error TS1309: The current file is a CommonJS module and cannot use 'await' at the top level.
export {x};
for await (const y of []) {}
~~~~~
!!! error TS1309: The current file is a CommonJS module and cannot use 'await' expressions at the top-level.
!!! error TS1309: The current file is a CommonJS module and cannot use 'await' at the top level.
==== tests/cases/conformance/node/allowJs/index.js (0 errors) ====
// esm format file
const x = await 1;
Expand Down
8 changes: 4 additions & 4 deletions tests/baselines/reference/nodeModulesAllowJsTopLevelAwait(module=nodenext).errors.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,16 @@
tests/cases/conformance/node/allowJs/subfolder/index.js(2,11): error TS1309: The current file is a CommonJS module and cannot use 'await' expressions at the top-level.
tests/cases/conformance/node/allowJs/subfolder/index.js(4,5): error TS1309: The current file is a CommonJS module and cannot use 'await' expressions at the top-level.
tests/cases/conformance/node/allowJs/subfolder/index.js(2,11): error TS1309: The current file is a CommonJS module and cannot use 'await' at the top level.
tests/cases/conformance/node/allowJs/subfolder/index.js(4,5): error TS1309: The current file is a CommonJS module and cannot use 'await' at the top level.


==== tests/cases/conformance/node/allowJs/subfolder/index.js (2 errors) ====
// cjs format file
const x = await 1;
~~~~~
!!! error TS1309: The current file is a CommonJS module and cannot use 'await' expressions at the top-level.
!!! error TS1309: The current file is a CommonJS module and cannot use 'await' at the top level.
export {x};
for await (const y of []) {}
~~~~~
!!! error TS1309: The current file is a CommonJS module and cannot use 'await' expressions at the top-level.
!!! error TS1309: The current file is a CommonJS module and cannot use 'await' at the top level.
==== tests/cases/conformance/node/allowJs/index.js (0 errors) ====
// esm format file
const x = await 1;
Expand Down
8 changes: 4 additions & 4 deletions tests/baselines/reference/nodeModulesTopLevelAwait(module=node16).errors.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,16 @@
tests/cases/conformance/node/subfolder/index.ts(2,11): error TS1309: The current file is a CommonJS module and cannot use 'await' expressions at the top-level.
tests/cases/conformance/node/subfolder/index.ts(4,5): error TS1309: The current file is a CommonJS module and cannot use 'await' expressions at the top-level.
tests/cases/conformance/node/subfolder/index.ts(2,11): error TS1309: The current file is a CommonJS module and cannot use 'await' at the top level.
tests/cases/conformance/node/subfolder/index.ts(4,5): error TS1309: The current file is a CommonJS module and cannot use 'await' at the top level.


==== tests/cases/conformance/node/subfolder/index.ts (2 errors) ====
// cjs format file
const x = await 1;
~~~~~
!!! error TS1309: The current file is a CommonJS module and cannot use 'await' expressions at the top-level.
!!! error TS1309: The current file is a CommonJS module and cannot use 'await' at the top level.
export {x};
for await (const y of []) {}
~~~~~
!!! error TS1309: The current file is a CommonJS module and cannot use 'await' expressions at the top-level.
!!! error TS1309: The current file is a CommonJS module and cannot use 'await' at the top level.
==== tests/cases/conformance/node/index.ts (0 errors) ====
// esm format file
const x = await 1;
Expand Down
8 changes: 4 additions & 4 deletions tests/baselines/reference/nodeModulesTopLevelAwait(module=nodenext).errors.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,16 @@
tests/cases/conformance/node/subfolder/index.ts(2,11): error TS1309: The current file is a CommonJS module and cannot use 'await' expressions at the top-level.
tests/cases/conformance/node/subfolder/index.ts(4,5): error TS1309: The current file is a CommonJS module and cannot use 'await' expressions at the top-level.
tests/cases/conformance/node/subfolder/index.ts(2,11): error TS1309: The current file is a CommonJS module and cannot use 'await' at the top level.
tests/cases/conformance/node/subfolder/index.ts(4,5): error TS1309: The current file is a CommonJS module and cannot use 'await' at the top level.


==== tests/cases/conformance/node/subfolder/index.ts (2 errors) ====
// cjs format file
const x = await 1;
~~~~~
!!! error TS1309: The current file is a CommonJS module and cannot use 'await' expressions at the top-level.
!!! error TS1309: The current file is a CommonJS module and cannot use 'await' at the top level.
export {x};
for await (const y of []) {}
~~~~~
!!! error TS1309: The current file is a CommonJS module and cannot use 'await' expressions at the top-level.
!!! error TS1309: The current file is a CommonJS module and cannot use 'await' at the top level.
==== tests/cases/conformance/node/index.ts (0 errors) ====
// esm format file
const x = await 1;
Expand Down