Skip to content

Don't go past import in cross-project renaming #48758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gabritto merged 8 commits into from
May 3, 2022
Merged

Don't go past import in cross-project renaming #48758

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
9acc88f
WIP
gabritto Feb 14, 2022
6804b7a
Merge branch 'main' into gabritto/issue45659
gabritto Apr 12, 2022
3242950
fix cross-project renaming logic
gabritto Apr 18, 2022
36af929
only use configure if prefix opt is defined
gabritto Apr 18, 2022
e0343f5
Merge branch 'main' into gabritto/issue45659
gabritto Apr 19, 2022
17ee2e1
refactor skipAlias into stopAtAlias
gabritto May 2, 2022
a6f2e0f
fix stopAtAlias
gabritto May 2, 2022
2d01675
update another stopAtAlias location
gabritto May 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge branch 'main' into gabritto/issue45659
  • Loading branch information
@gabritto
gabritto committed Apr 12, 2022
commit 6804b7a2ade8c4dbed3ca77bb44c4b5aaaeaf2fa
3 changes: 2 additions & 1 deletion src/server/session.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -312,7 +312,8 @@ namespace ts.server {
{ providePrefixAndSuffixTextForRename }: UserPreferences
): readonly RenameLocation[] {
const outputs: RenameLocation[] = [];
combineProjectOutputRenameWorker(
const seen = createDocumentSpanSet();
combineProjectOutputWorker(
projects,
defaultProject,
initialLocation,
Expand Down
You are viewing a condensed version of this merge commit. You can view the full changes here.