Skip to content

Clean up FAR aggregation #48619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
amcasey merged 11 commits into from
May 19, 2022
Merged

Clean up FAR aggregation #48619

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
99fa17e
Clean up FAR and RenameLocations
amcasey Feb 11, 2022
205a6e1
Stop enforcing search and aggregation order
amcasey Mar 30, 2022
fe0713f
Introduce LanguageService.updateIsDefinitionOfReferencedSymbols
amcasey Apr 7, 2022
12a78b0
Update baselines
amcasey Apr 7, 2022
b5fab0d
Tidy diff
amcasey Apr 7, 2022
5f088f6
De-dup simplified results
amcasey Apr 7, 2022
d9ff2cc
Baseline cross-project isDefinition results
amcasey Apr 7, 2022
7003203
Move de-duping upstream to fix Full output
amcasey Apr 8, 2022
780a84e
Add server baseline test to confirm searches are not repeated
amcasey Apr 8, 2022
d47ae8a
Manually merge #48758
amcasey May 17, 2022
827f5f3
Update baseline for newer fix to #48963
amcasey May 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Clean up FAR and RenameLocations 
This change had two goals:

1. Make the code easier to understand, primarily by simplifying the callback structure and minimizing side-effects
2. Improve performance by reducing repeated work, both FAR searches of individual projects and default tsconfig searches

This implementation attempts to preserve the merging order found in the original code (someone less relevant in the present state of using syntactic isDefinition).
  • Loading branch information
@amcasey
amcasey committed May 17, 2022
commit 99fa17e9a29a26bfbd8105f60de10044fa81812b
Loading