Skip to content

Only report isDefinition when FAR is triggered on a definition #48566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DanielRosenwasser merged 8 commits into from
Apr 6, 2022
Merged

Only report isDefinition when FAR is triggered on a definition #48566

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
03a1b28
Don't report isDefinition unless the starting node is a declaration
amcasey Mar 30, 2022
570c92e
Drop isDefinition everywhere it isn't specifically needed
amcasey Mar 30, 2022
3699146
Fix tsserver tests
amcasey Mar 31, 2022
d9a77fe
Update shim comment
amcasey Mar 31, 2022
c6108d8
Update baselines
amcasey Apr 5, 2022
2283e24
Add tests for isDefinition
amcasey Apr 5, 2022
891b51d
Update doc comment
amcasey Apr 5, 2022
e3b9256
Clear isDefinition from all references if the first one lacks it
amcasey Apr 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update shim comment
  • Loading branch information
@amcasey
amcasey committed Apr 5, 2022
commit d9a77fe90ade3013d66c87c75faecc20ccd20c36
2 changes: 1 addition & 1 deletion src/services/shims.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,7 +225,7 @@ namespace ts {

/**
* Returns a JSON-encoded value of the type:
* { fileName: string; highlights: { start: number; length: number, isDefinition: boolean }[] }[]
* { fileName: string; highlights: { start: number; length: number }[] }[]
*
* @param fileToSearch A JSON encoded string[] containing the file names that should be
* considered when searching.
Expand Down