Skip to content

FAR cleanup and isDefinition definition #48211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
amcasey wants to merge 10 commits into from
Closed

FAR cleanup and isDefinition definition #48211

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
b230065
First cut
amcasey Mar 7, 2022
cba96f3
Implement set with custom equals and getHashCode
amcasey Mar 7, 2022
cb1e800
Adopt custom set in session
amcasey Mar 8, 2022
3649f68
Revert to a syntactic implementation of isDefinition
amcasey Mar 1, 2022
c4cf396
Clean up FAR and RenameLocations
amcasey Feb 11, 2022
6241c4f
Stop enforcing search and aggregation order
amcasey Feb 19, 2022
d5df76a
Accept new baselines
amcasey Mar 7, 2022
46ce33e
Introduce LanguageService.updateIsDefinitionOfReferencedSymbols
amcasey Mar 2, 2022
c6cc433
Bound node search
amcasey Mar 10, 2022
a094f65
More todos
amcasey Mar 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
More todos
  • Loading branch information
@amcasey
amcasey committed Mar 10, 2022
commit a094f65d2ed82c32847214dc4ec7158b059a411d
4 changes: 3 additions & 1 deletion src/server/session.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -437,6 +437,8 @@ namespace ts.server {
// We need to de-duplicate and aggregate the results by choosing an authoritative version
// of each definition and merging references from all the projects where they appear.

// TODO (acasey): this work is redundant when giving simplified results

const results: ReferencedSymbol[] = [];

for (const [project, projectResults] of arrayFrom(perProjectResults.entries())) {
Expand Down Expand Up @@ -1649,7 +1651,7 @@ namespace ts.server {
const symbolStartOffset = nameSpan ? scriptInfo.positionToLineOffset(nameSpan.start).offset : 0;
const symbolName = nameSpan ? scriptInfo.getSnapshot().getText(nameSpan.start, textSpanEnd(nameSpan)) : "";
const refs: readonly protocol.ReferencesResponseItem[] = flatMap(references, referencedSymbol => {
return referencedSymbol.references.map(entry => referenceEntryToReferencesResponseItem(this.projectService, entry));
return referencedSymbol.references.map(entry => referenceEntryToReferencesResponseItem(this.projectService, entry)); // TODO (acasey): these should be de-dup'd
});
return { refs, symbolName, symbolStartOffset, symbolDisplayString };
}
Expand Down