fix types : export the base as children are exported#4815
Merged
Conversation
Member
|
Sorry about that, thanks for the fix @basarat! |
DanielRosenwasser
added a commit
that referenced
this pull request
Sep 16, 2015
fix types : export the base as children are exported
Member
|
Wait, I think this might need to go into release-1.6 as well @mhegazy. |
Member
|
Also, why did our tests never catch this? |
Member
|
Actually, it seems that this only occurs with |
Contributor
Author
As you mentioned: only occurs with --declaration and no --stripInternal 👍 Glad I could be of service. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes error:
Ref : https://travis-ci.org/TypeStrong/ntypescript/builds/80545233#L143-L144
🌹