Skip to content

Enable TS Server plugins on web #47377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rbuckton merged 12 commits into from
Jun 14, 2022
Merged

Enable TS Server plugins on web #47377

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
e2bbb6c
Prototype TS plugins on web
mjbvz Feb 16, 2022
53d90b6
use default export from plugins
mjbvz Feb 24, 2022
34a83a3
Allow configure plugin requests against any web servers in partial se…
mjbvz Mar 4, 2022
51680a1
Addressing some comments
mjbvz Mar 8, 2022
85e0fca
add tsserverWeb to patch in dynamic import
rbuckton May 4, 2022
f40a867
Remove eval
mjbvz May 10, 2022
186cec9
Ensure dynamically imported plugins are loaded in the correct order
rbuckton May 25, 2022
39dac60
Add tests for async service plugin timing
rbuckton May 25, 2022
78e016c
Update src/server/editorServices.ts
rbuckton Jun 3, 2022
c760041
Partial PR feedback
rbuckton Jun 4, 2022
9bc39d1
Rename tsserverWeb to dynamicImportCompat
rbuckton Jun 4, 2022
186f97e
Additional PR feedback
rbuckton Jun 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
use default export from plugins 
This more or less matches how node plugins expect the plugin module to be an init function
  • Loading branch information
@mjbvz
mjbvz committed Feb 24, 2022
commit 53d90b6636f90e3e5b8f96409e8a459c69b08c4b
2 changes: 1 addition & 1 deletion src/webServer/webServer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@ namespace ts.server {

// TODO: TS rewrites `import(...)` to `require`. Use eval to bypass this
// eslint-disable-next-line no-eval
return eval(`import(${JSON.stringify(scriptPath)})`);
return (await eval(`import(${JSON.stringify(scriptPath)})`)).default;
Comment thread
rbuckton marked this conversation as resolved.
Outdated
},
exit: notImplemented,

Expand Down