Only obtain regular type of fresh object literal type if necessary#4716
Merged
Conversation
Member
|
As discussed offline, the optimization of caching with |
Member
|
👍 |
ahejlsberg
added a commit
that referenced
this pull request
Sep 10, 2015
Only obtain regular type of fresh object literal type if necessary
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During type relalationship processing we currently obtain the regular (non-fresh) version of an object literal type after performing the excess property check. There's no reason to do this unless the type being compared against is a union or intersection type (which it rarely is). This PR implements that simple optimization.
No new tests in this PR as no behaviors change. Only difference is that we allocate fewer type instances.