Skip to content

Fix comment indentation#4638

Merged
DanielRosenwasser merged 3 commits into
microsoft:masterfrom
saschanaz:fixCommentIndentation
Sep 4, 2015
Merged

Fix comment indentation#4638
DanielRosenwasser merged 3 commits into
microsoft:masterfrom
saschanaz:fixCommentIndentation

Conversation

@saschanaz
Copy link
Copy Markdown
Contributor

@saschanaz saschanaz commented Sep 4, 2015

Fixes #4563.

Current:

_.chain()
// something here
    .then()
// something here
    .then();

foo(
    3
// something here
);

Fix:

_.chain()
    // something here
    .then()
    // something here
    .then();

foo(
    3
    // something here
);

@DanielRosenwasser
Copy link
Copy Markdown
Member

DanielRosenwasser commented Sep 4, 2015

👍, @mhegazy and @vladima can you take a look?

@vladima
Copy link
Copy Markdown
Contributor

vladima commented Sep 4, 2015

LGTM

@DanielRosenwasser
Copy link
Copy Markdown
Member

DanielRosenwasser commented Sep 4, 2015

Great work @saschanaz!

DanielRosenwasser added a commit that referenced this pull request Sep 4, 2015
@DanielRosenwasser
Merge pull request #4638 from SaschaNaz/fixCommentIndentation
6c23a6b 
Fix comment indentation
@DanielRosenwasser DanielRosenwasser merged commit 6c23a6b into microsoft:master Sep 4, 2015
@saschanaz saschanaz deleted the fixCommentIndentation branch September 5, 2015 17:11
@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@saschanaz @DanielRosenwasser @vladima @msftclas