Skip to content

Create type aliases for unresolved type symbols #45976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ahejlsberg merged 8 commits into from
Sep 23, 2021
Merged

Create type aliases for unresolved type symbols #45976

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
981cbb3
Create type aliases for unresolved type symbols
ahejlsberg Sep 20, 2021
17332e1
Accept new baselines
ahejlsberg Sep 20, 2021
3d34ca7
Update fourslash tests
ahejlsberg Sep 20, 2021
8f828c4
Unresolved import aliases create tagged unresolved symbols
ahejlsberg Sep 21, 2021
891f961
Add comments
ahejlsberg Sep 23, 2021
e949c85
Merge branch 'main' into fix45893
ahejlsberg Sep 23, 2021
5314074
Accept new baselines
ahejlsberg Sep 23, 2021
9d01571
Add fourslash tests
ahejlsberg Sep 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Accept new baselines
  • Loading branch information
@ahejlsberg
ahejlsberg committed Sep 23, 2021
commit 5314074b0369bb8972a1779bbc0308b1a4b79bfe
2 changes: 1 addition & 1 deletion tests/baselines/reference/ambientExternalModuleWithRelativeExternalImportDeclaration.symbols
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ declare module "OuterModule" {
public x: m2.c;
>x : Symbol(SubModule.x, Decl(ambientExternalModuleWithRelativeExternalImportDeclaration.ts, 4, 35))
>m2 : Symbol(m2, Decl(ambientExternalModuleWithRelativeExternalImportDeclaration.ts, 0, 30))
>c : Symbol(m2)
>c : Symbol(m2.c)

constructor();
}
Expand Down
2 changes: 1 addition & 1 deletion tests/baselines/reference/ambientExternalModuleWithRelativeExternalImportDeclaration.types
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ declare module "OuterModule" {
>InstanceVar : number

public x: m2.c;
>x : any
>x : m2.c
>m2 : any

constructor();
Expand Down
34 changes: 17 additions & 17 deletions tests/baselines/reference/asyncAwaitIsolatedModules_es2017.types
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ declare var p: Promise<number>;
>p : Promise<number>

declare var mp: MyPromise<number>;
>mp : any
>mp : MyPromise<number>

async function f0() { }
>f0 : () => Promise<void>
Expand All @@ -15,7 +15,7 @@ async function f1(): Promise<void> { }
>f1 : () => Promise<void>

async function f3(): MyPromise<void> { }
>f3 : () => any
>f3 : () => MyPromise<void>

let f4 = async function() { }
>f4 : () => Promise<void>
Expand All @@ -26,8 +26,8 @@ let f5 = async function(): Promise<void> { }
>async function(): Promise<void> { } : () => Promise<void>

let f6 = async function(): MyPromise<void> { }
>f6 : () => any
>async function(): MyPromise<void> { } : () => any
>f6 : () => MyPromise<void>
>async function(): MyPromise<void> { } : () => MyPromise<void>

let f7 = async () => { };
>f7 : () => Promise<void>
Expand All @@ -38,32 +38,32 @@ let f8 = async (): Promise<void> => { };
>async (): Promise<void> => { } : () => Promise<void>

let f9 = async (): MyPromise<void> => { };
>f9 : () => any
>async (): MyPromise<void> => { } : () => any
>f9 : () => MyPromise<void>
>async (): MyPromise<void> => { } : () => MyPromise<void>

let f10 = async () => p;
>f10 : () => Promise<number>
>async () => p : () => Promise<number>
>p : Promise<number>

let f11 = async () => mp;
>f11 : () => Promise<any>
>async () => mp : () => Promise<any>
>mp : any
>f11 : () => Promise<MyPromise<number>>
>async () => mp : () => Promise<MyPromise<number>>
>mp : MyPromise<number>

let f12 = async (): Promise<number> => mp;
>f12 : () => Promise<number>
>async (): Promise<number> => mp : () => Promise<number>
>mp : any
>mp : MyPromise<number>

let f13 = async (): MyPromise<number> => p;
>f13 : () => any
>async (): MyPromise<number> => p : () => any
>f13 : () => MyPromise<number>
>async (): MyPromise<number> => p : () => MyPromise<number>
>p : Promise<number>

let o = {
>o : { m1(): Promise<void>; m2(): Promise<void>; m3(): any; }
>{ async m1() { }, async m2(): Promise<void> { }, async m3(): MyPromise<void> { }} : { m1(): Promise<void>; m2(): Promise<void>; m3(): any; }
>o : { m1(): Promise<void>; m2(): Promise<void>; m3(): MyPromise<void>; }
>{ async m1() { }, async m2(): Promise<void> { }, async m3(): MyPromise<void> { }} : { m1(): Promise<void>; m2(): Promise<void>; m3(): MyPromise<void>; }

async m1() { },
>m1 : () => Promise<void>
Expand All @@ -72,7 +72,7 @@ let o = {
>m2 : () => Promise<void>

async m3(): MyPromise<void> { }
>m3 : () => any
>m3 : () => MyPromise<void>

};

Expand All @@ -86,7 +86,7 @@ class C {
>m2 : () => Promise<void>

async m3(): MyPromise<void> { }
>m3 : () => any
>m3 : () => MyPromise<void>

static async m4() { }
>m4 : () => Promise<void>
Expand All @@ -95,7 +95,7 @@ class C {
>m5 : () => Promise<void>

static async m6(): MyPromise<void> { }
>m6 : () => any
>m6 : () => MyPromise<void>
}

module M {
Expand Down
34 changes: 17 additions & 17 deletions tests/baselines/reference/asyncAwaitIsolatedModules_es5.types
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ declare var p: Promise<number>;
>p : Promise<number>

declare var mp: MyPromise<number>;
>mp : any
>mp : MyPromise<number>

async function f0() { }
>f0 : () => Promise<void>
Expand All @@ -15,7 +15,7 @@ async function f1(): Promise<void> { }
>f1 : () => Promise<void>

async function f3(): MyPromise<void> { }
>f3 : () => any
>f3 : () => MyPromise<void>

let f4 = async function() { }
>f4 : () => Promise<void>
Expand All @@ -26,8 +26,8 @@ let f5 = async function(): Promise<void> { }
>async function(): Promise<void> { } : () => Promise<void>

let f6 = async function(): MyPromise<void> { }
>f6 : () => any
>async function(): MyPromise<void> { } : () => any
>f6 : () => MyPromise<void>
>async function(): MyPromise<void> { } : () => MyPromise<void>

let f7 = async () => { };
>f7 : () => Promise<void>
Expand All @@ -38,32 +38,32 @@ let f8 = async (): Promise<void> => { };
>async (): Promise<void> => { } : () => Promise<void>

let f9 = async (): MyPromise<void> => { };
>f9 : () => any
>async (): MyPromise<void> => { } : () => any
>f9 : () => MyPromise<void>
>async (): MyPromise<void> => { } : () => MyPromise<void>

let f10 = async () => p;
>f10 : () => Promise<number>
>async () => p : () => Promise<number>
>p : Promise<number>

let f11 = async () => mp;
>f11 : () => Promise<any>
>async () => mp : () => Promise<any>
>mp : any
>f11 : () => Promise<MyPromise<number>>
>async () => mp : () => Promise<MyPromise<number>>
>mp : MyPromise<number>

let f12 = async (): Promise<number> => mp;
>f12 : () => Promise<number>
>async (): Promise<number> => mp : () => Promise<number>
>mp : any
>mp : MyPromise<number>

let f13 = async (): MyPromise<number> => p;
>f13 : () => any
>async (): MyPromise<number> => p : () => any
>f13 : () => MyPromise<number>
>async (): MyPromise<number> => p : () => MyPromise<number>
>p : Promise<number>

let o = {
>o : { m1(): Promise<void>; m2(): Promise<void>; m3(): any; }
>{ async m1() { }, async m2(): Promise<void> { }, async m3(): MyPromise<void> { }} : { m1(): Promise<void>; m2(): Promise<void>; m3(): any; }
>o : { m1(): Promise<void>; m2(): Promise<void>; m3(): MyPromise<void>; }
>{ async m1() { }, async m2(): Promise<void> { }, async m3(): MyPromise<void> { }} : { m1(): Promise<void>; m2(): Promise<void>; m3(): MyPromise<void>; }

async m1() { },
>m1 : () => Promise<void>
Expand All @@ -72,7 +72,7 @@ let o = {
>m2 : () => Promise<void>

async m3(): MyPromise<void> { }
>m3 : () => any
>m3 : () => MyPromise<void>

};

Expand All @@ -86,7 +86,7 @@ class C {
>m2 : () => Promise<void>

async m3(): MyPromise<void> { }
>m3 : () => any
>m3 : () => MyPromise<void>

static async m4() { }
>m4 : () => Promise<void>
Expand All @@ -95,7 +95,7 @@ class C {
>m5 : () => Promise<void>

static async m6(): MyPromise<void> { }
>m6 : () => any
>m6 : () => MyPromise<void>
}

module M {
Expand Down
34 changes: 17 additions & 17 deletions tests/baselines/reference/asyncAwaitIsolatedModules_es6.types
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ declare var p: Promise<number>;
>p : Promise<number>

declare var mp: MyPromise<number>;
>mp : any
>mp : MyPromise<number>

async function f0() { }
>f0 : () => Promise<void>
Expand All @@ -15,7 +15,7 @@ async function f1(): Promise<void> { }
>f1 : () => Promise<void>

async function f3(): MyPromise<void> { }
>f3 : () => any
>f3 : () => MyPromise<void>

let f4 = async function() { }
>f4 : () => Promise<void>
Expand All @@ -26,8 +26,8 @@ let f5 = async function(): Promise<void> { }
>async function(): Promise<void> { } : () => Promise<void>

let f6 = async function(): MyPromise<void> { }
>f6 : () => any
>async function(): MyPromise<void> { } : () => any
>f6 : () => MyPromise<void>
>async function(): MyPromise<void> { } : () => MyPromise<void>

let f7 = async () => { };
>f7 : () => Promise<void>
Expand All @@ -38,32 +38,32 @@ let f8 = async (): Promise<void> => { };
>async (): Promise<void> => { } : () => Promise<void>

let f9 = async (): MyPromise<void> => { };
>f9 : () => any
>async (): MyPromise<void> => { } : () => any
>f9 : () => MyPromise<void>
>async (): MyPromise<void> => { } : () => MyPromise<void>

let f10 = async () => p;
>f10 : () => Promise<number>
>async () => p : () => Promise<number>
>p : Promise<number>

let f11 = async () => mp;
>f11 : () => Promise<any>
>async () => mp : () => Promise<any>
>mp : any
>f11 : () => Promise<MyPromise<number>>
>async () => mp : () => Promise<MyPromise<number>>
>mp : MyPromise<number>

let f12 = async (): Promise<number> => mp;
>f12 : () => Promise<number>
>async (): Promise<number> => mp : () => Promise<number>
>mp : any
>mp : MyPromise<number>

let f13 = async (): MyPromise<number> => p;
>f13 : () => any
>async (): MyPromise<number> => p : () => any
>f13 : () => MyPromise<number>
>async (): MyPromise<number> => p : () => MyPromise<number>
>p : Promise<number>

let o = {
>o : { m1(): Promise<void>; m2(): Promise<void>; m3(): any; }
>{ async m1() { }, async m2(): Promise<void> { }, async m3(): MyPromise<void> { }} : { m1(): Promise<void>; m2(): Promise<void>; m3(): any; }
>o : { m1(): Promise<void>; m2(): Promise<void>; m3(): MyPromise<void>; }
>{ async m1() { }, async m2(): Promise<void> { }, async m3(): MyPromise<void> { }} : { m1(): Promise<void>; m2(): Promise<void>; m3(): MyPromise<void>; }

async m1() { },
>m1 : () => Promise<void>
Expand All @@ -72,7 +72,7 @@ let o = {
>m2 : () => Promise<void>

async m3(): MyPromise<void> { }
>m3 : () => any
>m3 : () => MyPromise<void>

};

Expand All @@ -86,7 +86,7 @@ class C {
>m2 : () => Promise<void>

async m3(): MyPromise<void> { }
>m3 : () => any
>m3 : () => MyPromise<void>

static async m4() { }
>m4 : () => Promise<void>
Expand All @@ -95,7 +95,7 @@ class C {
>m5 : () => Promise<void>

static async m6(): MyPromise<void> { }
>m6 : () => any
>m6 : () => MyPromise<void>
}

module M {
Expand Down
4 changes: 2 additions & 2 deletions tests/baselines/reference/badExternalModuleReference.symbols
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,11 +8,11 @@ export declare var a: {
test1: a1.connectModule;
>test1 : Symbol(test1, Decl(badExternalModuleReference.ts, 1, 23))
>a1 : Symbol(a1, Decl(badExternalModuleReference.ts, 0, 0))
>connectModule : Symbol(a1)
>connectModule : Symbol(a1.connectModule)

(): a1.connectExport;
>a1 : Symbol(a1, Decl(badExternalModuleReference.ts, 0, 0))
>connectExport : Symbol(a1)
>connectExport : Symbol(a1.connectExport)

};

4 changes: 2 additions & 2 deletions tests/baselines/reference/badExternalModuleReference.types
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,10 @@ import a1 = require("garbage");
>a1 : any

export declare var a: {
>a : { (): any; test1: any; }
>a : { (): a1.connectExport; test1: a1.connectModule; }

test1: a1.connectModule;
>test1 : any
>test1 : a1.connectModule
>a1 : any

(): a1.connectExport;
Expand Down
2 changes: 2 additions & 0 deletions tests/baselines/reference/constAssertionOnEnum.symbols
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@ namespace ns {
>ns : Symbol(ns, Decl(ns.ts, 0, 0))
>Foo : Symbol(Foo, Decl(ns.ts, 0, 14))
>X : Symbol(Foo.X, Decl(ns.ts, 1, 21))
>const : Symbol(const)
}

=== tests/cases/conformance/expressions/typeAssertions/more.ts ===
Expand All @@ -61,4 +62,5 @@ export enum Foo { X }
>(Foo).X : Symbol(Foo.X, Decl(more.ts, 0, 17))
>Foo : Symbol(Foo, Decl(more.ts, 0, 0))
>X : Symbol(Foo.X, Decl(more.ts, 0, 17))
>const : Symbol(const)

2 changes: 1 addition & 1 deletion tests/baselines/reference/constructorWithIncompleteTypeAnnotation.symbols
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ module TypeScriptAllInOne {
var local5 = <fs.File>null;
>local5 : Symbol(local5, Decl(constructorWithIncompleteTypeAnnotation.ts, 74, 15))
>fs : Symbol(fs, Decl(constructorWithIncompleteTypeAnnotation.ts, 8, 1))
>File : Symbol(fs)
>File : Symbol(fs.File)

var local6 = local5 instanceof fs.File;
>local6 : Symbol(local6, Decl(constructorWithIncompleteTypeAnnotation.ts, 75, 15))
Expand Down
6 changes: 3 additions & 3 deletions tests/baselines/reference/constructorWithIncompleteTypeAnnotation.types
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,15 +200,15 @@ module TypeScriptAllInOne {
>local : number

var local5 = <fs.File>null;
>local5 : any
><fs.File>null : any
>local5 : fs.File
><fs.File>null : fs.File
>fs : any
>null : null

var local6 = local5 instanceof fs.File;
>local6 : boolean
>local5 instanceof fs.File : boolean
>local5 : any
>local5 : fs.File
>fs.File : any
>fs : any
>File : any
Expand Down
4 changes: 2 additions & 2 deletions tests/baselines/reference/decoratorMetadataWithImportDeclarationNameCollision4.symbols
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,12 +27,12 @@ class MyClass {
db: db.db;
>db : Symbol(MyClass.db, Decl(service.ts, 5, 15))
>db : Symbol(db, Decl(service.ts, 0, 6))
>db : Symbol(db)
>db : Symbol(db.db)

constructor(db: db.db) {
>db : Symbol(db, Decl(service.ts, 8, 16))
>db : Symbol(db, Decl(service.ts, 0, 6))
>db : Symbol(db)
>db : Symbol(db.db)

this.db = db;
>this.db : Symbol(MyClass.db, Decl(service.ts, 5, 15))
Expand Down
Loading