Skip to content

Control flow analysis of aliased conditional expressions and discriminants #44730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ahejlsberg merged 5 commits into from
Jun 25, 2021
Merged

Control flow analysis of aliased conditional expressions and discriminants #44730

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
08b6e2e
CFA inlining of conditional expressions referenced by const variables
ahejlsberg Jun 24, 2021
0bed057
Accept new baselines
ahejlsberg Jun 24, 2021
ad81160
Add tests
ahejlsberg Jun 25, 2021
82c601e
Accept new baselines
ahejlsberg Jun 25, 2021
9a68c4f
Increase inlining limit to 5 levels per design meeting discussion
ahejlsberg Jun 25, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Accept new baselines
  • Loading branch information
@ahejlsberg
ahejlsberg committed Jun 24, 2021
commit 0bed0574083cdec49833cec1fc342e2e7481e93a
2 changes: 1 addition & 1 deletion tests/baselines/reference/controlFlowCommaExpressionAssertionWithinTernary.types
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ function foo2(param: number | null | undefined): number | null {
>assert(param !== undefined) : void
>assert : (value: any) => asserts value
>param !== undefined : boolean
>param : number | null | undefined
>param : number | null
>undefined : undefined
>param : number | null
>null : null
Expand Down
2 changes: 1 addition & 1 deletion tests/baselines/reference/logicalAndOperatorStrictMode.types
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -256,7 +256,7 @@ const v5 = v && v;
>v5 : void
>v && v : void
>v : void
>v : void
>v : never

const v6 = v && u;
>v6 : void
Expand Down
2 changes: 1 addition & 1 deletion tests/baselines/reference/logicalAndOperatorWithEveryType.types
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -300,7 +300,7 @@ var re5 = a5 && a5;
>re5 : void
>a5 && a5 : void
>a5 : void
>a5 : void
>a5 : never

var re6 = a6 && a5;
>re6 : void
Expand Down
4 changes: 2 additions & 2 deletions tests/baselines/reference/voidIsInitialized.types
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ if(typeof x === "undefined") {
>"undefined" : "undefined"

x // no error: assume x2 is initialised
>x : void
>x : undefined
}

if(typeof y !== "undefined") {
Expand All @@ -24,6 +24,6 @@ if(typeof y !== "undefined") {
>"undefined" : "undefined"

y // no error: do not narrow void
>y : void
>y : never
}