Cache anonymous object type instantiations#4464
Merged
Merged
Conversation
Member
Author
|
Tests copied from #4456. |
Member
|
Can you also add this test?
|
Member
Author
|
@DanielRosenwasser Don't think we need that test. It doesn't really test anything new, rather it just reveals an issue with the solution in #4456 that doesn't apply here. |
Member
|
👍 |
Contributor
|
👍 |
Member
|
@JsonFreeman what are the cases in which it didn't work? |
Contributor
|
@DanielRosenwasser, we fixed those already. See PR #3316 and #3452 (there are links to related issues there). |
ahejlsberg
added a commit
that referenced
this pull request
Aug 26, 2015
Cache anonymous object type instantiations
Member
|
@ahejlsberg can you cherry pick this into |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4443.
This PR adds a cache to
TypeMapperwhich caches instantiations of anonymous object types previously created using that type mapper. The PR supercedes #4456.