Add arguments to completion list #4249#4347
Merged
Merged
Conversation
|
Hi @Schmavery, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution! TTYL, MSBOT; |
Member
There was a problem hiding this comment.
This isn't quite right. Arrow functions shouldn't automatically get an arguments in the completion list, nor does it get them in call signatures, etc.
Add the following to utilities.ts
function introducesArgumentsExoticObject(node: Node) {
switch (decl.kind) {
SyntaxKind.MethodDeclaration:
SyntaxKind.MethodSignature:
SyntaxKind.Constructor:
SyntaxKind.GetAccessor:
SyntaxKind.SetAccessor:
SyntaxKind.FunctionDeclaration:
SyntaxKind.FunctionExpression:
return true;
}
return false;
}Then use that here. I'd add a test like
function f() {
let g = () => /*shouldHaveArguments*/
}
let g = () => /*shouldNotHaveArguments*/
mhegazy
added a commit
that referenced
this pull request
Aug 18, 2015
Add `arguments` to completion list #4249
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here's my attempt to fix issue #4249.