Report error if class uses extended type before its declaration#4343
Closed
sheetalkamat wants to merge 20 commits into
Closed
Report error if class uses extended type before its declaration#4343sheetalkamat wants to merge 20 commits into
sheetalkamat wants to merge 20 commits into
Conversation
Contributor
There was a problem hiding this comment.
i would also add a test with an expression in an extend clause, class A extends foo(0)<string> {}
and one for module aliases
import d from "mod";
class B extends d { // no error here
}… report error Fixes #4244
Member
Author
|
I am still working on reporting error if alias is declared before it is referencing entity(internal alias only) |
Contributor
There was a problem hiding this comment.
Why are they allowed to be in different lexical scopes?
Contributor
There was a problem hiding this comment.
use ts.indexOf instead of array.prototype.indexof
Contributor
There was a problem hiding this comment.
Fix spacing at the end of the line
Member
|
This PR is superseded by #8636 which has been successfully merged, right? |
Contributor
|
closing in favor of #8636 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4341