Conversation
…ile. Also add a more conservative check for empty refPos and refEnd to ensure diagnostic emit does not fail
Member
There was a problem hiding this comment.
Make a helper function for this
Contributor
Author
There was a problem hiding this comment.
i thought about that, but this seems easier to read and a reminder why we are doing it this way.
Member
|
I think this may have been the cause of some issues I was having with "fancy" diagnostic reporting. I'd like to see how it copes after this change. |
Contributor
Author
|
@DanielRosenwasser any more comments? |
Member
|
👍 |
mhegazy
added a commit
that referenced
this pull request
Aug 17, 2015
Fix #4277: Ensure we are passing refEnd and not length to findSourceFile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4277
There was a confusion on the fifth argument to findSoruceFile, some places will send the refEnd, others will send the refLength. this will trigger an assert when writing the diagnostics if the refLength > file text length.
The fix is to ensure we are always calling it with the right argument, also added a more conservative check for empty refPos and refEnd to ensure diagnostic emit does not fail