Add Intellisense to JsDoc#4283
Merged
Merged
Conversation
Author
|
@billti @CyrusNajmabadi could you take a look |
Member
There was a problem hiding this comment.
These branches are identical, just let each fall through and use a variable typeTagOrParamTag of type JSDocTypeTag | JSDocParamTag.
Contributor
There was a problem hiding this comment.
consider caching the result. these are not going to change between invocations. saves you the allocations.
see keywordCompletions for an example.
Member
There was a problem hiding this comment.
Remove the type annotation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR provides completion list for the following cases:
@sign or in the tagname, e.g.:and
The initial implementation only applies to js files, as currently the parser stores the
JSDocCommentnodes in the tree for js files but not ts files. Support for ts files may need some discussion.