Skip to content

Leading and middle rest elements in tuple types #41544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ahejlsberg merged 7 commits into from
Jan 5, 2021
Merged

Leading and middle rest elements in tuple types #41544

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
08c0a6c
Support starting and middle rest elements in tuples
ahejlsberg Nov 13, 2020
c9b8bd1
Accept new baselines
ahejlsberg Nov 13, 2020
9c27739
Include all rest arguments in error span
ahejlsberg Nov 14, 2020
af4d6f5
Accept new baselines
ahejlsberg Nov 14, 2020
23de9f2
Fix tests
ahejlsberg Nov 14, 2020
87d8b5b
Add new tests
ahejlsberg Nov 14, 2020
77722bb
Fix lint errors
ahejlsberg Nov 15, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Include all rest arguments in error span
  • Loading branch information
@ahejlsberg
ahejlsberg committed Nov 14, 2020
commit 9c277396915b09ede48b49466998e47e9db85cc3
6 changes: 5 additions & 1 deletion src/compiler/checker.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26926,7 +26926,11 @@ namespace ts {
}
if (restType) {
const spreadType = getSpreadArgumentType(args, argCount, args.length, restType, /*context*/ undefined, checkMode);
const errorNode = reportErrors ? argCount < args.length ? args[argCount] : node : undefined;
const restArgCount = args.length - argCount;
const errorNode = !reportErrors ? undefined :
restArgCount === 0 ? node :
restArgCount === 1 ? args[argCount] :
setTextRangePosEnd(createSyntheticExpression(node, spreadType), args[argCount].pos, args[args.length - 1].end);
if (!checkTypeRelatedTo(spreadType, restType, relation, errorNode, headMessage, /*containingMessageChain*/ undefined, errorOutputContainer)) {
Debug.assert(!reportErrors || !!errorOutputContainer.errors, "rest parameter should have errors when reporting errors");
maybeAddMissingAwaitInfo(errorNode, spreadType, restType);
Expand Down