Skip to content

Control flow for constructor initialized properties #37920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ahejlsberg merged 10 commits into from
Apr 28, 2020
Merged

Control flow for constructor initialized properties #37920

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
2fbab38
Use CFA to determine types of properties declared by this.xxx assignm…
ahejlsberg Apr 12, 2020
957d9e6
Accept new baselines
ahejlsberg Apr 12, 2020
6e0274a
Also use CFA in constructor functions
ahejlsberg Apr 14, 2020
df98d9c
Accept new baselines
ahejlsberg Apr 14, 2020
0c9c76a
Fix lint error
ahejlsberg Apr 14, 2020
728d9cb
Only widen fresh literal types in CFA of assignment to auto-typed
ahejlsberg Apr 16, 2020
fa6fee8
Auto-typing for declared properties with no type annotation or initia…
ahejlsberg Apr 21, 2020
e6d7607
Add optionality if declaration includes '?' modifier
ahejlsberg Apr 21, 2020
33cbb82
Always use CFA for properties with no initializer in .js files
ahejlsberg Apr 21, 2020
ab993c2
Small fix
ahejlsberg Apr 21, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Always use CFA for properties with no initializer in .js files
  • Loading branch information
@ahejlsberg
ahejlsberg committed Apr 21, 2020
commit 33cbb82a37e677e9e272e5963e3a51939df471da
6 changes: 3 additions & 3 deletions src/compiler/checker.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7484,9 +7484,9 @@ namespace ts {
return addOptionality(type, isOptional);
}

if (noImplicitAny && isPropertyDeclaration(declaration)) {
// We are in noImplicitAny mode and have a property declaration with no type annotation or initializer. Use
// control flow analysis of this.xxx assignments the constructor to determine the type of the property.
if (isPropertyDeclaration(declaration) && (noImplicitAny || isInJSFile(declaration))) {
// We have a property declaration with no type annotation or initializer, in noImplicitAny mode or a .js file.
// Use control flow analysis of this.xxx assignments the constructor to determine the type of the property.
const constructor = findConstructorDeclaration(declaration.parent);
const type = constructor ? getFlowTypeInConstructor(declaration.symbol, constructor) :
getModifierFlags(declaration) & ModifierFlags.Ambient ? getTypeOfPropertyInBaseClass(declaration.symbol) :
Expand Down