Conversation
Conflicts: src/compiler/commandLineParser.ts src/compiler/emitter.ts
Member
There was a problem hiding this comment.
I'll be honest, "emitBOM" seems more appropriate, and is shorter.
But I don't feel particularly strongly about it and we can roll with this.
Contributor
Author
There was a problem hiding this comment.
like this more.. will change it
Member
|
👍 |
mhegazy
added a commit
that referenced
this pull request
Aug 7, 2014
add a new compiler command line switch for generating utf-8 BOM in the output
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously we trafficked BOM from input to output. the only scenario where we know a BOM is necessary in the output is WWA's. This change adds a new switch (--generateBOM) that a WWA project would enable and get the same result.