Don't give back completions after stray dots#3727
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
consider moving the check to the top of the function along with other completion blocking checks.
Contributor
There was a problem hiding this comment.
also jsx spread expression should be in this list.. somthing like <div {.../*here*/
Member
Author
|
All good now @mhegazy? |
Contributor
|
👍 |
DanielRosenwasser
added a commit
that referenced
this pull request
Jul 7, 2015
Don't give back completions after stray dots
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3242.