Skip to content

Abstract constructor assignability#3722

Merged
aozgaa merged 13 commits into
masterfrom
abstractConstructorAssignability
Jul 13, 2015
Merged

Abstract constructor assignability#3722
aozgaa merged 13 commits into
masterfrom
abstractConstructorAssignability

Conversation

@aozgaa
Copy link
Copy Markdown
Contributor

@aozgaa aozgaa commented Jul 2, 2015

Fixes #3702 .

Comment thread src/compiler/diagnosticMessages.json Outdated
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sounds a little verbose. Maybe something like

Cannot assign an abstract constructor to a concrete constructor.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe "constructor type"

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed to "Cannot assign an abstract constructor type to a non-abstract constructor type."

@JsonFreeman
Copy link
Copy Markdown
Contributor

👍

aozgaa pushed a commit that referenced this pull request Jul 13, 2015
@aozgaa aozgaa merged commit 7664f34 into master Jul 13, 2015
@aozgaa aozgaa deleted the abstractConstructorAssignability branch July 14, 2015 00:03
@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants