Skip to content

Abstract extra error #3712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aozgaa merged 3 commits into from
Jul 2, 2015
Merged

Abstract extra error #3712

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0647203
Prevent extra checks once abstract new-call detected
Jul 2, 2015
61a9a64
Added conformance test
Jul 2, 2015
2331531
updated baselines
Jul 2, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/compiler/checker.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8456,6 +8456,7 @@ namespace ts {
let valueDecl = expressionType.symbol && getDeclarationOfKind(expressionType.symbol, SyntaxKind.ClassDeclaration);
if (valueDecl && valueDecl.flags & NodeFlags.Abstract) {
error(node, Diagnostics.Cannot_create_an_instance_of_the_abstract_class_0, declarationNameToString(valueDecl.name));
return resolveErrorCall(node);
}

// TS 1.0 spec: 4.11
Expand Down
8 changes: 6 additions & 2 deletions tests/baselines/reference/classAbstractInstantiations1.errors.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
tests/cases/conformance/classes/classDeclarations/classAbstractKeyword/classAbstractInstantiations1.ts(8,1): error TS2511: Cannot create an instance of the abstract class 'A'.
tests/cases/conformance/classes/classDeclarations/classAbstractKeyword/classAbstractInstantiations1.ts(10,1): error TS2511: Cannot create an instance of the abstract class 'C'.
tests/cases/conformance/classes/classDeclarations/classAbstractKeyword/classAbstractInstantiations1.ts(9,1): error TS2511: Cannot create an instance of the abstract class 'A'.
tests/cases/conformance/classes/classDeclarations/classAbstractKeyword/classAbstractInstantiations1.ts(11,1): error TS2511: Cannot create an instance of the abstract class 'C'.


==== tests/cases/conformance/classes/classDeclarations/classAbstractKeyword/classAbstractInstantiations1.ts (2 errors) ====
==== tests/cases/conformance/classes/classDeclarations/classAbstractKeyword/classAbstractInstantiations1.ts (3 errors) ====

abstract class A {}

Expand All @@ -12,6 +13,9 @@ tests/cases/conformance/classes/classDeclarations/classAbstractKeyword/classAbst

new A;
~~~~~
!!! error TS2511: Cannot create an instance of the abstract class 'A'.
new A(1); // should report 1 error
~~~~~~~~
!!! error TS2511: Cannot create an instance of the abstract class 'A'.
new B;
new C;
Expand Down
2 changes: 2 additions & 0 deletions tests/baselines/reference/classAbstractInstantiations1.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ class B extends A {}
abstract class C extends B {}

new A;
new A(1); // should report 1 error
new B;
new C;

Expand Down Expand Up @@ -45,6 +46,7 @@ var C = (function (_super) {
return C;
})(B);
new A;
new A(1); // should report 1 error
new B;
new C;
var a;
Expand Down
1 change: 1 addition & 0 deletions ...onformance/classes/classDeclarations/classAbstractKeyword/classAbstractInstantiations1.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ class B extends A {}
abstract class C extends B {}

new A;
new A(1); // should report 1 error
new B;
new C;

Expand Down