Don't show a builder for property names in object binding patterns#3698
Merged
Conversation
Contributor
There was a problem hiding this comment.
Can you make this an else if on the destructuring syntaxkind, so reading this code it's obvious what's happening.
e4cfca0 to
422a405
Compare
Contributor
There was a problem hiding this comment.
I would call this tryGetContextualPropertyNameOrNameInScope. If that's too long, it's because the function is trying to do too many unrelated things.
Contributor
|
👍 |
DanielRosenwasser
added a commit
that referenced
this pull request
Jul 6, 2015
Don't show a builder for property names in object binding patterns
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.