Fixed memory leak when using '--watch' flag.#367
Merged
DanielRosenwasser merged 3 commits intoAug 6, 2014
Conversation
As I initially feared, we were actually nesting closure environments with each new `getSourceFile`. Fixes #366.
Member
Author
There was a problem hiding this comment.
One could even imagine filtering out the changed files from this list, and I'll totally do that if everyone else feels it would be appropriate tomorrow.
Contributor
|
LGTM |
Contributor
There was a problem hiding this comment.
this seems highly unnecessary, esp. as you overwrite 'program' just a few lines later.
Member
Author
There was a problem hiding this comment.
You're right; releasing doesn't seem to have a noticeable effect on memory footprint from what I can tell anyway.
Member
|
👍 |
DanielRosenwasser
added a commit
that referenced
this pull request
Aug 6, 2014
…nceOfMemory Fixed memory leak when using '--watch' flag.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were actually nesting closure environments with each new
getSourceFile. Instead we now just aggregate the source files into a map.Fixes #366.