Repository navigation
Remove distinction between CI lint and local lint - #36430
Merged
Wesley Wigham (weswigham) merged 1 commit intoJan 25, 2020
Merged
Wesley Wigham (weswigham) merged 1 commit into
Wesley Wigham (weswigham) merged 1 commit into
Conversation
Wesley Wigham (weswigham)
requested review from
Andrew Casey (amcasey),
Ron Buckton (rbuckton) and
Ben Lichtman (uniqueiniquity)
January 24, 2020 22:59
Ben Lichtman (uniqueiniquity)
approved these changes
Jan 24, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
And move all the CI only rules back into the normal rule definitions. The overall lint time isn't really a concern locally anymore, since we have incremental lints now. A change to
checker.ts, even with semantic lints, still only takes a few seconds to lint. So the difference mostly just served to frustrate when you discover a CI-only lint failure. 😄