Always emit any for get accessors#36279
Closed
DanielRosenwasser wants to merge 2 commits into
Closed
Conversation
…ors in older TypeScript versions.
Member
Author
|
@typescript-bot cherry-pick this to release-3.7 |
Collaborator
|
Hey @DanielRosenwasser, I couldn't open a PR with the cherry-pick. (You can check the log here). You may need to squash and pick this PR into release-3.7 manually. |
Contributor
|
Don't we normally elide the type annotation for |
Member
|
Eeeyes? I think so. Unsure. @sandersn ? |
Member
Author
|
Correct, in #36216 it was reported that 3.6.x incorrectly thinks that an error under |
Member
Author
Member
|
@rbuckton is right, we elide the type annotation for private declarations. The correct thing is not to error on then, so I don't think we should take this PR. |
sandersn
requested changes
Jan 22, 2020
Member
sandersn
left a comment
There was a problem hiding this comment.
We should not error instead of emitting an any type.
Member
Author
|
I'm potentially okay with that - can you check out #36280 then? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes at least half of #36216 by always emitting
anyforgetaccessors.Note that
setaccessors stil emit without parameter types, and from what I can tell TypeScript 3.6 is okay with that undernoImplicitAny.