Skip to content

Speed up getAccessibleFileSystemEntries #36139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
amcasey wants to merge 3 commits into from
Closed

Speed up getAccessibleFileSystemEntries #36139

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
59ae33d
Speed up getAccessibleFileSystemEntries
amcasey Jan 11, 2020
490f736
Restore sorting behavior
amcasey Jan 11, 2020
c71f9a9
Restore the old implementation for Node < 10.10
amcasey Jan 11, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Restore sorting behavior
  • Loading branch information
@amcasey
amcasey committed Jan 11, 2020
commit 490f736ccb501d58656da81ccd4b507026edcc67
4 changes: 2 additions & 2 deletions src/compiler/sys.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1617,7 +1617,7 @@ namespace ts {
function getAccessibleFileSystemEntries(path: string): FileSystemEntries {
perfLogger.logEvent("ReadDir: " + (path || "."));
try {
const entries = _fs.readdirSync(path || ".", { withFileTypes: true }).sort();
const entries = _fs.readdirSync(path || ".", { withFileTypes: true });
const files: string[] = [];
const directories: string[] = [];
for (const entry of entries) {
Expand All @@ -1634,7 +1634,7 @@ namespace ts {
directories.push(entryName);
}
}
return { files, directories };
return { files: files.sort(), directories: directories.sort() };
}
catch (e) {
return emptyFileSystemEntries;
Expand Down