Skip to content

Go to definition for type predicate#3611

Merged
mhegazy merged 4 commits into
microsoft:masterfrom
tinganho:goToDefinitionTypePredicate
Jun 24, 2015
Merged

Go to definition for type predicate#3611
mhegazy merged 4 commits into
microsoft:masterfrom
tinganho:goToDefinitionTypePredicate

Conversation

@tinganho
Copy link
Copy Markdown
Contributor

Fixes #3600.

Comment thread src/compiler/checker.ts Outdated
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: We usually don't put space around the name for the comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, I also noticed that the parameter name is without plural. Fixed now.

@DanielRosenwasser
Copy link
Copy Markdown
Member

👍

@mhegazy
Copy link
Copy Markdown
Contributor

mhegazy commented Jun 24, 2015

thanks!

mhegazy added a commit that referenced this pull request Jun 24, 2015
@mhegazy mhegazy merged commit 20b4b7f into microsoft:master Jun 24, 2015
@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants