Skip to content

Emit declarations of namespaces correctly#3545

Merged
mhegazy merged 3 commits into
masterfrom
emitNamespaces
Jun 18, 2015
Merged

Emit declarations of namespaces correctly#3545
mhegazy merged 3 commits into
masterfrom
emitNamespaces

Conversation

@mhegazy
Copy link
Copy Markdown
Contributor

@mhegazy mhegazy commented Jun 18, 2015

Fixes #3544. This is a follow up to #3491, emits namespace declarations as namespaces instead of modules.

Comment thread Jakefile.js Outdated
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider making this (namespace|module)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point. fixed.

@DanielRosenwasser
Copy link
Copy Markdown
Member

👍

@DanielRosenwasser DanielRosenwasser changed the title Emit declarations of namespaces correctelly Emit declarations of namespaces correctly Jun 18, 2015
mhegazy added a commit that referenced this pull request Jun 18, 2015
Emit declarations of namespaces correctly
@mhegazy mhegazy merged commit 6db4faf into master Jun 18, 2015
@mhegazy mhegazy deleted the emitNamespaces branch June 18, 2015 06:56
@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants