Parse class member with a missing identifier in the presence of a modifier#3515
Merged
Merged
Conversation
Contributor
Author
|
@CyrusNajmabadi want to take a look? |
Contributor
|
👍 |
JsonFreeman
added a commit
that referenced
this pull request
Jun 17, 2015
Parse class member with a missing identifier in the presence of a modifier
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3504.
Our parser function isClassMemberStart treats
public {}as a class member because it starts with the word "public". Starting with a modifier is enough evidence to consider it a class member. However, parseClassElement is not so forgiving. It expects to see an identifier after the word "public". It does have a special case for a decorator with no identifier after it, so I'm piggy backing on this fallback logic for modifiers as well.