Skip to content

Support the '--help' compiler flag.#351

Merged
DanielRosenwasser merged 9 commits into
masterfrom
wontYouPleasePleaseHelpMe
Aug 6, 2014
Merged

Support the '--help' compiler flag.#351
DanielRosenwasser merged 9 commits into
masterfrom
wontYouPleasePleaseHelpMe

Conversation

@DanielRosenwasser
Copy link
Copy Markdown
Member

Fixes #269.

Comment thread scripts/processDiagnosticMessages.ts Outdated
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be left broken down for readability.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agreed. We also shouldn't be using these default values here. The 'isFixed' in particularly is quite hard to read.

@mhegazy
Copy link
Copy Markdown
Contributor

mhegazy commented Aug 4, 2014

👍

Comment thread src/compiler/tc.ts Outdated
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why a.name.toLowerCase ? that's not needed we would be printing the name as it is so we shouldn't do lowercase on this

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just for the sort; we're displaying the names as intended, but our sort is based on case-insensitive lexicographic ordering.

This is ideal because, "sourcemap" should occur before "sourceRoot".

DanielRosenwasser added a commit that referenced this pull request Aug 6, 2014
@DanielRosenwasser DanielRosenwasser merged commit 3ad6e31 into master Aug 6, 2014
@DanielRosenwasser DanielRosenwasser deleted the wontYouPleasePleaseHelpMe branch August 6, 2014 22:49
@microsoft microsoft locked and limited conversation to collaborators Jun 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support --help in the new compiler

7 participants