Move json declaration file emit behind a experimentalJsonDeclarationEmit flag#34962
Closed
weswigham wants to merge 1 commit into
Closed
Move json declaration file emit behind a experimentalJsonDeclarationEmit flag#34962weswigham wants to merge 1 commit into
experimentalJsonDeclarationEmit flag#34962weswigham wants to merge 1 commit into
Conversation
|
What happend with this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This way it can still be opted in to while we're iterating on it (with the caveat that certain things may change), and we can still track all of the tests related to it while we work. This seems a little nicer than attempting to strip the feature out entirely, as it gives us a way to backport the fixes we make in 3.8 before unflagging it to 3.7 without breaking anyone who didn't opt-in (and allows anyone who started using it with Monday's release to still have a way to use it in the 3.7 branch).