🤖 Cherry-pick PR #34679 into release-3.7#34681
Merged
DanielRosenwasser merged 2 commits intoOct 23, 2019
Merged
Conversation
Component commits: e0b98c6 Do not consider element accesses which are neither statically bindable nor late bound as special assignments
2151f64 to
d428e59
Compare
| return ts.isPropertyAccessExpression(node) || isLiteralLikeElementAccess(node); | ||
| } | ||
| ts.isLiteralLikeAccess = isLiteralLikeAccess; | ||
| /** x[0] OR x['a'] OR x[Symbol.y] */ |
Member
There was a problem hiding this comment.
Note: It is kind of silly that this doesn't work for negative numbers, but nobody's asked for it so...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This cherry-pick was triggerd by a request on #34679
Please review the diff and merge if no changes are unexpected. An LKG update commit is included seperately from the base change.
You can view the cherry-pick log here.
cc @DanielRosenwasser