Skip to content

Do not write build info if there are no files to emit#34487

Merged
sheetalkamat merged 4 commits into
masterfrom
skipTsBuildinfoEmit
Oct 17, 2019
Merged

Do not write build info if there are no files to emit#34487
sheetalkamat merged 4 commits into
masterfrom
skipTsBuildinfoEmit

Conversation

@sheetalkamat
Copy link
Copy Markdown
Member

No description provided.

Copy link
Copy Markdown
Contributor

@orta orta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me

@weswigham
Copy link
Copy Markdown
Member

What about if every project input is a declaration file (so the intent is just to check declaration file validity once)? Without a bundle info, won't we recheck every time?

@sheetalkamat
Copy link
Copy Markdown
Member Author

sheetalkamat commented Oct 17, 2019

What about if every project input is a declaration file (so the intent is just to check declaration file validity once)? Without a bundle info, won't we recheck every time?

In that case changeSet wont be empty so we would emit the bundle info.
I will add test though

@sheetalkamat sheetalkamat merged commit 4055689 into master Oct 17, 2019
@sheetalkamat sheetalkamat deleted the skipTsBuildinfoEmit branch October 17, 2019 19:22
@microsoft microsoft locked as resolved and limited conversation to collaborators Oct 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants