Conversation
weswigham
approved these changes
Oct 2, 2019
Member
weswigham
left a comment
There was a problem hiding this comment.
Much friendlier - this means some custom transforms might just support optional chains out of the box (maybe not wholly correctly, but in some way without crashing).
weswigham
reviewed
Oct 2, 2019
| export function updatePropertyAccess(node: PropertyAccessExpression, expression: Expression, name: Identifier) { | ||
| Debug.assert(!(node.flags & NodeFlags.OptionalChain), "Cannot update a PropertyAccessChain using updatePropertyAccess. Use updatePropertyAccessChain instead."); | ||
| if (isOptionalChain(node)) { | ||
| return updatePropertyAccessChain(node, expression, node.questionDotToken, name); |
Member
There was a problem hiding this comment.
I imagine if we had a way to emit a deprecation warning, we'd do it here.
Contributor
Author
There was a problem hiding this comment.
I'm working on that elsewhere...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relaxing the assertions on
updateCall/updatePropertyAccess/updateElementAccesswhen used with aCallChain/PropertyAccessChain/ElementAccessChainto fix a crash in the TS transform and to improve backwards/forwards compatibility with external consumers of the API.If you call any of the three mentioned
updateXfunctions on anXChainnode, the correspondingupdateXChainfunction is called instead with the current value ofnode.questionDotTokenpassed as thequestionDotTokenargument.Fixes #33744