Fix issue when types installed after watch/editor is opened for auto type reference that is for global types not being detected#33681
Merged
Conversation
…type reference that is for global types not being detected Fixes #32285
andrewbranch
approved these changes
Oct 1, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the code doesn't have any other resolution, if auto type references are not invalidated program will think its upto date since file versions have not change (there is no module resolution from files included by program that failed or changed). So setting the changed auto type reference included being change when the file is not a program file but a inferredTypes file, will handle the situation.
Fixes #32285