Skip to content

introduce FileMap to store mappings with filenames as keys#3368

Merged
vladima merged 2 commits into
masterfrom
fileMap
Jun 4, 2015
Merged

introduce FileMap to store mappings with filenames as keys#3368
vladima merged 2 commits into
masterfrom
fileMap

Conversation

@vladima
Copy link
Copy Markdown
Contributor

@vladima vladima commented Jun 3, 2015

Filenames that come from tripleslash references\imports can differ in cases\slashes so they should be normalized before they can be used as keys

Comment thread src/compiler/core.ts Outdated
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i would switch this to function/interface pair

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't see a big problem for it to be class, but ok

@mhegazy
Copy link
Copy Markdown
Contributor

mhegazy commented Jun 3, 2015

👍

vladima added a commit that referenced this pull request Jun 4, 2015
introduce FileMap to store mappings with filenames as keys
@vladima vladima merged commit 113b7ed into master Jun 4, 2015
@vladima vladima deleted the fileMap branch June 4, 2015 06:13
@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants