Parse namespaces/types aliases/interfaces/ambient declarations only when they cannot be legal JS#3365
Merged
Conversation
Contributor
There was a problem hiding this comment.
You need some comment explaining why the lookahead is necessary here, but not for the syntaxkind kinds below.
Member
Author
|
Any more feedback @CyrusNajmabadi? |
Contributor
|
Nope. lgtm |
Contributor
There was a problem hiding this comment.
Do you still need these declaration flags checks? Are they redundant of the check you are adding?
Contributor
|
👍 |
DanielRosenwasser
added a commit
that referenced
this pull request
Jun 8, 2015
Parse namespaces/types aliases/interfaces/ambient declarations only when they cannot be legal JS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2995.
Previously, upon encountering a
module,namespace,type,interface, ordeclarekeyword, we would immediately launch into parsing out an "appropriate" declaration.However, this is inappropriate for reasons listed in issue #2995. These could actually be identifiers. To deal with this, we ensure that what we have is not legal JavaScript by adding a single token lookahead and checking for whether that token is an appropriate token on the same line.