Dom lib file bug fix#3354
Merged
Merged
Conversation
Fix microsoft#3344; removed duplicated overloads for ``createEvent`` and some minor fixes.
Contributor
There was a problem hiding this comment.
this is causing an error as DocumentEvent is not assignable to Event, as it does not inherit from it. is this by design?
Author
There was a problem hiding this comment.
This is not by design, it's because in the script I treated interfaces with a name ended with "Event" as event names. I added additional checking for the extended base interface to be 'Event', DocumentEvent turns out to be the only exception. Updating it soon.
Contributor
|
👍 |
Contributor
|
this needs to get into release-1.5 branch. We need to check RWC results first though. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #3344; removed duplicated overloads for
createEventand someminor fixes.