🤖 User test baselines have changed#33083
Merged
sandersn merged 1 commit intoAug 28, 2019
Merged
Conversation
f0c5818 to
3e78c9e
Compare
sandersn
approved these changes
Aug 28, 2019
| XX of XX: [@azure/core-tracing] completed successfully in ? seconds | ||
| XX of XX: [@azure/service-bus] completed successfully in ? seconds | ||
| Warning: You have changed the public API signature for this project. Updating review/cosmos.api.md | ||
| dist-esm/index.js → dist/index.js... |
Member
There was a problem hiding this comment.
these warnings are new, and might be bad.
| node_modules/async/dist/async.js(1768,38): error TS2532: Object is possibly 'undefined'. | ||
| node_modules/async/dist/async.js(1769,3): error TS2532: Object is possibly 'undefined'. | ||
| node_modules/async/dist/async.js(1773,35): error TS2532: Object is possibly 'undefined'. | ||
| node_modules/async/dist/async.js(1951,10): error TS1003: Identifier expected. |
Member
There was a problem hiding this comment.
more lenient jsdoc parsing? (there is a stray trailing -: @param- {Object} [guard])
| node_modules/bluebird/js/release/using.js(97,23): error TS2339: Property 'data' does not exist on type 'FunctionDisposer'. | ||
| node_modules/bluebird/js/release/using.js(131,72): error TS2339: Property 'classString' does not exist on type 'typeof ret'. | ||
| node_modules/bluebird/js/release/using.js(223,15): error TS2350: Only a void function can be called with the 'new' keyword. | ||
| node_modules/bluebird/js/release/util.js(200,32): error TS2339: Property 'foo' does not exist on type 'FakeConstructor'. |
Member
There was a problem hiding this comment.
prototype now has type any, which means that all property accesses are allowed now.
| @@ -262,34 +262,26 @@ node_modules/chrome-devtools-frontend/front_end/animation/AnimationModel.js(514, | |||
| node_modules/chrome-devtools-frontend/front_end/animation/AnimationModel.js(553,11): error TS2339: Property 'AnimationModel' does not exist on type '{ new (effect?: AnimationEffect, timeline?: AnimationTimeline): Animation; prototype: Animation; }'. | |||
| node_modules/chrome-devtools-frontend/front_end/animation/AnimationModel.js(583,43): error TS2339: Property 'remove' does not exist on type 'Map<string, AnimationGroup>'. | |||
| node_modules/chrome-devtools-frontend/front_end/animation/AnimationModel.js(665,37): error TS2339: Property 'AnimationModel' does not exist on type '{ new (effect?: AnimationEffect, timeline?: AnimationTimeline): Animation; prototype: Animation; }'. | |||
| node_modules/chrome-devtools-frontend/front_end/animation/AnimationModel.js(691,24): error TS2749: 'Image' refers to a value, but is being used as a type here. | |||
Member
There was a problem hiding this comment.
stricter jsdoc type resolution, I think. probably good?
Member
There was a problem hiding this comment.
well, uh, sort of. It's now silently any, which seems wrong. I filed a bug #33106.
| node_modules/chrome-devtools-frontend/front_end/animation/AnimationTimeline.js(8,11): error TS2339: Property 'AnimationTimeline' does not exist on type '{ new (effect?: AnimationEffect, timeline?: AnimationTimeline): Animation; prototype: Animation; }'. | ||
| node_modules/chrome-devtools-frontend/front_end/animation/AnimationTimeline.js(14,38): error TS2339: Property 'createSVGChild' does not exist on type 'Element'. | ||
| node_modules/chrome-devtools-frontend/front_end/animation/AnimationTimeline.js(19,53): error TS2339: Property 'createChild' does not exist on type 'Element'. | ||
| node_modules/chrome-devtools-frontend/front_end/animation/AnimationTimeline.js(20,44): error TS2339: Property 'createChild' does not exist on type 'Element'. | ||
| node_modules/chrome-devtools-frontend/front_end/animation/AnimationTimeline.js(21,32): error TS2554: Expected 2 arguments, but got 1. | ||
| node_modules/chrome-devtools-frontend/front_end/animation/AnimationTimeline.js(26,32): error TS2694: Namespace 'Protocol' has no exported member 'DOM'. | ||
| node_modules/chrome-devtools-frontend/front_end/animation/AnimationTimeline.js(36,47): error TS2339: Property 'AnimationModel' does not exist on type '{ new (effect?: AnimationEffect, timeline?: AnimationTimeline): Animation; prototype: Animation; }'. | ||
| node_modules/chrome-devtools-frontend/front_end/animation/AnimationTimeline.js(36,63): error TS2345: Argument of type 'this' is not assignable to parameter of type '{ modelAdded(model: T): void; modelRemoved(model: T): void; }'. | ||
| Type 'AnimationTimeline' is not assignable to type '{ modelAdded(model: T): void; modelRemoved(model: T): void; }'. |
Member
There was a problem hiding this comment.
real classes = better error messages
| node_modules/chrome-devtools-frontend/front_end/text_editor/CodeMirrorTextEditor.js(251,22): error TS2339: Property 'name' does not exist on type 'void'. | ||
| node_modules/chrome-devtools-frontend/front_end/text_editor/CodeMirrorTextEditor.js(252,22): error TS2339: Property 'token' does not exist on type 'void'. | ||
| node_modules/chrome-devtools-frontend/front_end/text_editor/CodeMirrorTextEditor.js(252,70): error TS2339: Property 'token' does not exist on type 'void'. | ||
| node_modules/chrome-devtools-frontend/front_end/text_editor/CodeMirrorTextEditor.js(283,13): error TS2403: Subsequent variable declarations must have the same type. Variable 'extension' must be of type 'Extension', but here has type 'any'. | ||
| node_modules/chrome-devtools-frontend/front_end/text_editor/CodeMirrorTextEditor.js(391,57): error TS2362: The left-hand side of an arithmetic operation must be of type 'any', 'number', 'bigint' or an enum type. |
Member
There was a problem hiding this comment.
these errors are also not in 3.5, and were incorrect errors.
| @@ -10928,16 +11001,24 @@ node_modules/chrome-devtools-frontend/front_end/text_editor/CodeMirrorTextEditor | |||
| node_modules/chrome-devtools-frontend/front_end/text_editor/CodeMirrorTextEditor.js(1637,61): error TS2339: Property 'line' does not exist on type 'void'. | |||
| node_modules/chrome-devtools-frontend/front_end/text_editor/CodeMirrorTextEditor.js(1637,71): error TS2339: Property 'ch' does not exist on type 'void'. | |||
| node_modules/chrome-devtools-frontend/front_end/text_editor/CodeMirrorTextEditor.js(1647,14): error TS7014: Function type, which lacks return-type annotation, implicitly has an 'any' return type. | |||
| node_modules/chrome-devtools-frontend/front_end/text_editor/CodeMirrorUtils.js(57,53): error TS2345: Argument of type 'Pos' is not assignable to parameter of type 'Pos'. | |||
| Type 'Pos' is missing the following properties from type 'Pos': line, ch | |||
Member
There was a problem hiding this comment.
better typedef resolution? it's to do with less anys anyway. Not sure why this didn't work before.
| @@ -11081,9 +11166,6 @@ node_modules/chrome-devtools-frontend/front_end/timeline/TimelineEventOverview.j | |||
| node_modules/chrome-devtools-frontend/front_end/timeline/TimelineEventOverview.js(204,36): error TS2339: Property '_overviewIndex' does not exist on type 'TimelineCategory'. | |||
| node_modules/chrome-devtools-frontend/front_end/timeline/TimelineEventOverview.js(246,68): error TS2339: Property 'peekLast' does not exist on type 'any[]'. | |||
| node_modules/chrome-devtools-frontend/front_end/timeline/TimelineEventOverview.js(248,81): error TS2339: Property '_overviewIndex' does not exist on type 'TimelineCategory'. | |||
| node_modules/chrome-devtools-frontend/front_end/timeline/TimelineEventOverview.js(384,7): error TS2322: Type 'Promise<HTMLImageElement | (new (width?: number, height?: number) => HTMLImageElement)>' is not assignable to type 'Promise<HTMLImageElement>'. | |||
| Type 'HTMLImageElement | (new (width?: number, height?: number) => HTMLImageElement)' is not assignable to type 'HTMLImageElement'. | |||
| Type 'new (width?: number, height?: number) => HTMLImageElement' is missing the following properties from type 'HTMLImageElement': align, alt, border, complete, and 261 more. | |||
Member
There was a problem hiding this comment.
better type resolution of Image
| node_modules/chrome-devtools-frontend/front_end/timeline_model/TimelineProfileTree.js(168,31): error TS2345: Argument of type 'string | symbol' is not assignable to parameter of type 'string'. | ||
| Type 'symbol' is not assignable to type 'string'. | ||
| node_modules/chrome-devtools-frontend/front_end/timeline_model/TimelineProfileTree.js(170,66): error TS2345: Argument of type 'string | symbol' is not assignable to parameter of type 'string'. |
Member
There was a problem hiding this comment.
not sure how we missed this type error before, but perhaps we forgot to check for assignability in the constructor function special-case code?
| node_modules/lodash/_unicodeWords.js(62,20): error TS8024: JSDoc '@param' tag has name 'The', but there is no parameter with that name. | ||
| node_modules/lodash/_updateWrapDetails.js(34,5): error TS1223: 'returns' tag already specified. | ||
| node_modules/lodash/_wrapperClone.js(14,20): error TS2339: Property 'clone' does not exist on type 'LazyWrapper'. | ||
| node_modules/lodash/ary.js(16,10): error TS1003: Identifier expected. |
sandersn
reviewed
Aug 28, 2019
| src/controllers/user.ts(145,28): error TS2339: Property 'id' does not exist on type 'User'. | ||
| src/controllers/user.ts(181,28): error TS2339: Property 'id' does not exist on type 'User'. | ||
| src/controllers/user.ts(197,33): error TS2339: Property 'id' does not exist on type 'User'. | ||
| src/controllers/user.ts(211,28): error TS2339: Property 'id' does not exist on type 'User'. |
Member
There was a problem hiding this comment.
pretty sure this is @types/express' fault because it's fine pre-npm-install on both 3.5 and 3.7.
Member
There was a problem hiding this comment.
Yep, this is a DT change that should be reverted.
timsuchanek
pushed a commit
to timsuchanek/TypeScript
that referenced
this pull request
Sep 11, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please review the diff and merge if no changes are unexpected.
You can view the build log here.
cc @weswigham @sandersn @RyanCavanaugh