Add assert comments in CodeFixes and Refactors#33016
Merged
Merged
Conversation
sheetalkamat
approved these changes
Aug 21, 2019
timsuchanek
pushed a commit
to timsuchanek/TypeScript
that referenced
this pull request
Sep 11, 2019
* Add comments to assert calls * Add comments to assert calls in codefixes * So linty
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our telemetry-sourced bugs have a ton of call stacks like this, where it isn't obvious which refactor triggered it (tons of them have a
doChangefunction) and it isn't obvious which assert failed without checking out very specific versions of tsserver.js and digging into the line numbers:This PR adds messages to all the
assert*family calls in these two folders. As a follow-up we could also do the same forcastas that has a few ambiguous stacks as well.In most cases I tried to make the assert messages globally unique rather than making them consistent, since this will make looking them up later easier.